1307507 - Resolution for outbound video stream drops to 352x288 on replacing video track during webrtc call.

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

The fix in bug 1303279 works on the first replaceTrack/renegotiation, but fails in subsequent ones.  this is because mSendingWidth is reset to 0 later in that call, and if nothing else tweaks it, we'll fail to copy the data on future replace/renegotiations.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: ensure that resolution is retained on multiple replaceTrack/renegotiations

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/261a85a44357
ensure that resolution is retained on multiple replaceTrack/renegotiations r=bwc

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/261a85a44357

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8797665 [details] [diff] [review]
ensure that resolution is retained on multiple replaceTrack/renegotiations

Approval Request Comment
[Feature/regressing bug #]: See bug 1303279 - fix was incomplete

[User impact if declined]: A second replaceTrack or renegotiation/ICE-restart will cause the video resolution to switch to CIF (352x288)

[Describe test coverage new/current, TreeHerder]: manual testing.  Caught in additional post-landing testing the fix for bug 1303279

[Risks and why]: No risk - just moves some code into an else case, to avoid overwriting the state variables on renegotiation/etc.

[String/UUID change made/needed]: none

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8797665 [details] [diff] [review]
ensure that resolution is retained on multiple replaceTrack/renegotiations

Fixes a regression, Aurora51+, Beta50+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/911144fca18d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ddf1476b34c

Comment 8

[Cornel Ionce [:noni]]

Reproduced the initial issue using the attached URL on Firefox 49, build ID 20160916101415.

Confirming this issue no longer reproduces on:
* Fx 50 RC, build ID 20161101104304,
* Latest 51.0a2 Aurora, build ID 20161102004003,
* Latest 52.0a1 Nightly, build ID 20161102030205.