Closed Bug 1307507 Opened 5 years ago Closed 5 years ago

Resolution for outbound video stream drops to 352x288 on replacing video track during webrtc call.

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

49 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla52
Tracking Status
firefox49 --- wontfix
firefox-esr45 --- unaffected
firefox50 --- verified
firefox51 --- verified
firefox52 --- verified

People

(Reporter: jesup, Assigned: jesup)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

The fix in bug 1303279 works on the first replaceTrack/renegotiation, but fails in subsequent ones.  this is because mSendingWidth is reset to 0 later in that call, and if nothing else tweaks it, we'll fail to copy the data on future replace/renegotiations.
Rank: 10
Attachment #8797665 - Flags: review?(docfaraday) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/261a85a44357
ensure that resolution is retained on multiple replaceTrack/renegotiations r=bwc
https://hg.mozilla.org/mozilla-central/rev/261a85a44357
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8797665 [details] [diff] [review]
ensure that resolution is retained on multiple replaceTrack/renegotiations

Approval Request Comment
[Feature/regressing bug #]: See bug 1303279 - fix was incomplete

[User impact if declined]: A second replaceTrack or renegotiation/ICE-restart will cause the video resolution to switch to CIF (352x288)

[Describe test coverage new/current, TreeHerder]: manual testing.  Caught in additional post-landing testing the fix for bug 1303279

[Risks and why]: No risk - just moves some code into an else case, to avoid overwriting the state variables on renegotiation/etc.

[String/UUID change made/needed]: none
Attachment #8797665 - Flags: approval-mozilla-beta?
Attachment #8797665 - Flags: approval-mozilla-aurora?
Comment on attachment 8797665 [details] [diff] [review]
ensure that resolution is retained on multiple replaceTrack/renegotiations

Fixes a regression, Aurora51+, Beta50+
Attachment #8797665 - Flags: approval-mozilla-beta?
Attachment #8797665 - Flags: approval-mozilla-beta+
Attachment #8797665 - Flags: approval-mozilla-aurora?
Attachment #8797665 - Flags: approval-mozilla-aurora+
Reproduced the initial issue using the attached URL on Firefox 49, build ID 20160916101415.

Confirming this issue no longer reproduces on:
* Fx 50 RC, build ID 20161101104304,
* Latest 51.0a2 Aurora, build ID 20161102004003,
* Latest 52.0a1 Nightly, build ID 20161102030205.
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
You need to log in before you can comment on or make changes to this bug.