1307555 - Can't scroll over checkerboarding on treeherder

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P2)

Description

[Markus Stange [:mstange]]

STR:
 1. Go to https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound and wait for it to load completely.
 2. On macOS, using a touchpad / magic mouse, do the following very quickly:
   - Scroll down far and fast
   - Lift your fingers and set them back down
   - Scroll up
   such that the new input block is started while the mouse is over checkerboarding.

The scroll up gesture is ignored.

This is probably reproducible on other platforms, but it's harder to force start a new mousewheel transaction before the checkerboarding has stopped.

Comment 1

[Markus Stange [:mstange]]

It would be nice if fixing this bug resulted in something I could use for overscroll - I need wheel events inside the overscroll "trough" to target the overscrolled scroll frame.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I've seen this on Fennec as well (bug 1278390 comment 3, second paragraph). I thought I filed something for that but can't find it now.

Comment 3

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 4

[Botond Ballo [:botond]]

I've been talking about this with Markus, and we have two ideas for how to fix this.

The problem appears to be that during checkerboarding, the checkerboaded areas are not part of the hit region (or DTC region) of the layer for the scrollable content that's checkerboarding. As a result, that layer doesn't get hit during hit testing (its parent does).

  1) This suggests the hit region is clipped to the displayport.
     We could try not clipping it.

  2) We could modify APZ hit testing so that, if none of the
     event regions of a layer nor of its descendants are hit,
     but the layer is scrollable and has a composition bounds
     clip, and the hit testing is inside that clip, we still
     hit the layer.

Comment 5

[Botond Ballo [:botond]]

I'm going to try fixing this.

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1307555 - Mochitest.

Review commit: https://reviewboard.mozilla.org/r/223338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223338/

Comment 7

[Botond Ballo [:botond]]

Doing proper TDD for a change and writing the test first :)

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8954179 [details]
Bug 1307555 - Mochitest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223338/diff/1-2/

Comment 9

[Botond Ballo [:botond]]

Attachment: Bug 1307555 - Create a hit test info item for a scroll frame's scrolled frame that's not clipped to the displayport.

Review commit: https://reviewboard.mozilla.org/r/224776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224776/

Comment 10

[Botond Ballo [:botond]]

Comment on attachment 8954179 [details]
Bug 1307555 - Mochitest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223338/diff/2-3/

Comment 11

[Botond Ballo [:botond]]

Markus, could you also apply the patches and see if they fix the problem in the scenarios in which you've noticed it? Thanks!

Comment 12

[Botond Ballo [:botond]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=55de38ee676370ad797150ae2bb6cfaf87d2370a

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8954179 [details]
Bug 1307555 - Mochitest.

https://reviewboard.mozilla.org/r/223338/#review230830

Looks like a good test, thanks!

Comment 14

[Markus Stange [:mstange]]

Comment on attachment 8955697 [details]
Bug 1307555 - Create a hit test info item for a scroll frame's scrolled frame that's not clipped to the displayport.

https://reviewboard.mozilla.org/r/224776/#review232474

This looks good and I suspect that it's going to make my life a lot easier when implementing overscrolling. (I'll probably need to override the rectangle to something bigger, though.)
I haven't actually tested this patch yet, but there's no reason not to r+ and land it in the meantime. Sorry for the delay!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9910fc2faa6
Create a hit test info item for a scroll frame's scrolled frame that's not clipped to the displayport. r=mstange
https://hg.mozilla.org/integration/autoland/rev/3a4d96efd68f
Mochitest. r=kats

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d9910fc2faa6
https://hg.mozilla.org/mozilla-central/rev/3a4d96efd68f