Open Bug 1307556 Opened 5 years ago Updated 6 months ago

System Addon updates should be in the same timer as Firefox updates, not as Add-ons updates

Categories

(Toolkit :: Add-ons Manager, defect, P3)

defect

Tracking

()

REOPENED

People

(Reporter: Felipe, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [system add-on])

On an official release build, the Firefox update timer is 12hrs, and the Add-ons update timer is 24hr.  This is ok for general add-ons, and (I imagine) important for the load on the versioncheck AMO server. But System Addons are more akin to Firefox features, and the update ping is served by the same Firefox update server (as I understand it).
(In reply to :Felipe Gomes (needinfo me!) from comment #0)
> On an official release build, the Firefox update timer is 12hrs, and the
> Add-ons update timer is 24hr.  This is ok for general add-ons, and (I
> imagine) important for the load on the versioncheck AMO server. But System
> Addons are more akin to Firefox features, and the update ping is served by
> the same Firefox update server (as I understand it).

This makes sense to me. We do use the Firefox update server (Balrog) for both system add-ons and GMP (Gecko Media Plugins). Right now the check is triggered here, in `AddonManagerInternal.backgroundUpdateCheck()`:

https://dxr.mozilla.org/mozilla-central/rev/42c95d88aaaa7c2eca1d278399421d437441ac4d/toolkit/mozapps/extensions/AddonManager.jsm#1588
Blocks: 1307569
Whiteboard: [system add-on]
What is blocking doing this fix sooner rather than later?  I know rob is measuring in bug 1307568 - but this Sounds like a known area that is stopping system add-on updates.   this is a blocker for expanding add-ons/e10s in Fx52 (high visibility). system add-on updates are our best failsafe to stop enabling e10s with an add-on, when stuff goes wrong in Release, but right now the reach is too limited.
Severity: normal → critical
Flags: needinfo?(rhelmer)
Flags: needinfo?(dtownsend)
Flags: needinfo?(aswan)
Priority: -- → P1
This shouldn't be blocking system add-on updates - they just happen during the add-ons update timer rather than the app updates timer.
Flags: needinfo?(rhelmer)
Flags: needinfo?(dtownsend)
I agree with comment 3, and I don't think P1/critical is right for this bug.
Flags: needinfo?(aswan)
dropping priority unless data analysis shows are root cause.  likely not impactful
Severity: critical → normal
Priority: P1 → P3
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
You need to log in before you can comment on or make changes to this bug.