Closed
Bug 1307580
Opened 8 years ago
Closed 8 years ago
Preferences Pane should show Debugger source maps checkbox
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
Details
Attachments
(1 file, 2 obsolete files)
|
5.66 KB,
patch
|
jlong
:
review+
|
Details | Diff | Splinter Review |
Screen Shot 2016-10-04 at 4.04.42 PM.png
We're currently adding support for source maps in the new debugger. When this lands, it will be helpful to toggle support in a couple of cases.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jlaster
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8797743 -
Flags: review?(jlong)
|
|
Assignee | |
Comment 2•8 years ago
|
||
^ this was a quick pass, but i'm curious to get your feedback. After this lands, it'll be fairly easy to update shouldUseSourceMaps to refer back to Prefs as well, both locally with the Prefs shim and natively.
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8797743 [details] [diff] [review] source-map-pref.patch Review of attachment 8797743 [details] [diff] [review]: ----------------------------------------------------------------- This looks great, thanks for figuring this out! Unfortunately, we need a new pref. This pref will turn on sourcemaps client-side too. We one which just the client-side can check. I'd rather we used a new pref though, because that would allow us to work with older Firefox versions easily (we'd turn off the native sourcemaps from them, and use our own). What do you think/
|
|
Assignee | |
Comment 4•8 years ago
|
||
added a new pref
Attachment #8797742 -
Attachment is obsolete: true
Attachment #8797743 -
Attachment is obsolete: true
Attachment #8797743 -
Flags: review?(jlong)
Attachment #8798593 -
Flags: review?(jlong)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8798593 [details] [diff] [review] source-map-pref2.patch Review of attachment 8798593 [details] [diff] [review]: ----------------------------------------------------------------- Awesome, thanks! Maybe we'll aim to land this tomorrow if we feel good about updating the debugger too.
Attachment #8798593 -
Flags: review?(jlong) → review+
Pushed by jlong@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/ba53dda46a53 Preferences Pane should show Debugger source maps checkbox. r=jlongster
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ba53dda46a53
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Comment 8•7 years ago
|
||
The Preferences Pane is now showing Debugger source maps checkbox on Beta 52.0b8 Build ID 20170220070057 User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 [bugday-20170301]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•