Closed
Bug 1307595
Opened 8 years ago
Closed 8 years ago
Videos on my.xfinity.net do not play again
Categories
(Core :: Audio/Video: Playback, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox49 | --- | unaffected |
firefox50 | --- | unaffected |
firefox51 | --- | verified |
firefox52 | --- | verified |
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug, )
Details
(Keywords: regression)
Attachments
(1 file)
1.66 KB,
patch
|
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 1280829 fixed video playback at http://my.xfinity.com/video/ but it regressed again between 2016-09-28 and 2016-09-29.
Comment 1•8 years ago
|
||
[Tracking Requested - why for this release]: This is an EME regression in Nightly 52 from bug 1280829.
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
status-firefox52:
--- → affected
tracking-firefox52:
--- → ?
Keywords: regression
Assignee | ||
Comment 2•8 years ago
|
||
This is a regression from Bug 1300654, that landed with an incorrect merge conflict resolution which effectively backed out bug 1280829: https://hg.mozilla.org/mozilla-central/rev/8eef5d2cc850#l8.108
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff26deb4079871216636252d24fa0dceb6b67c98 Bug 1307595 - Fixup bad merge conflict resolution from Bug 1300654/8eef5d2cc850. r=partial-backout
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Chris Pearce (:cpearce) from comment #3) > https://hg.mozilla.org/integration/mozilla-inbound/rev/ > ff26deb4079871216636252d24fa0dceb6b67c98 > Bug 1307595 - Fixup bad merge conflict resolution from Bug > 1300654/8eef5d2cc850. r=partial-backout Partial backout of the incorrect merge conflict resolution.
Assignee | ||
Comment 5•8 years ago
|
||
8eef5d2cc850 in Bug 1300654 incorrectly resolved a merge conflict and backed out part of the fix for Bug 1280829. Relanding. MozReview-Commit-ID: 6DIkUrc9R4t
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8797850 [details] [diff] [review] Fixup bad merge conflict resolution from Bug 1300654/8eef5d2cc850 Approval Request Comment [Feature/regressing bug #]: The build was broken on Aurora with the landing of bug 1299694. The fix for that is in bug 1300654, however that had a mismerge, so we also need this patch to fix the mismerge. [User impact if declined]: Some videos which setup EME but don't actually use EME will not play. [Describe test coverage new/current, TreeHerder]: We have a specific test to test this case, it's currently on aurroa. [Risks and why]: Low, fixing a bad merge. [String/UUID change made/needed]: None.
Attachment #8797850 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
Comment 7•8 years ago
|
||
Comment on attachment 8797850 [details] [diff] [review] Fixup bad merge conflict resolution from Bug 1300654/8eef5d2cc850 Fix a bad merge conflict. Take it in 51 aurora.
Attachment #8797850 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/af5a59737002cc4e8bb0f69acddb2583a9d952c6
tracking-firefox52:
? → ---
Comment 9•8 years ago
|
||
backout bugherder |
https://hg.mozilla.org/mozilla-central/rev/ff26deb40798
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
status-firefox49:
--- → unaffected
Version: unspecified → 51 Branch
Comment 10•8 years ago
|
||
This issue is verified fixed on latest Nightly/Aurora builds from 2016-10-10 on the following OSes: - Windows 7 x64 - Ubuntu 16.04 x64 LTS - Mac OS X 10.11.6
You need to log in
before you can comment on or make changes to this bug.
Description
•