Closed Bug 1307595 Opened 5 years ago Closed 5 years ago

Videos on my.xfinity.net do not play again

Categories

(Core :: Audio/Video: Playback, defect, P1)

51 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla52
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- verified
firefox52 --- verified

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug, )

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1280829 fixed video playback at http://my.xfinity.com/video/ but it regressed again between 2016-09-28 and 2016-09-29.
[Tracking Requested - why for this release]:

This is an EME regression in Nightly 52 from bug 1280829.
This is a regression from Bug 1300654, that landed with an incorrect merge conflict resolution which effectively backed out bug 1280829:

https://hg.mozilla.org/mozilla-central/rev/8eef5d2cc850#l8.108
(In reply to Chris Pearce (:cpearce) from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> ff26deb4079871216636252d24fa0dceb6b67c98
> Bug 1307595 - Fixup bad merge conflict resolution from Bug
> 1300654/8eef5d2cc850. r=partial-backout

Partial backout of the incorrect merge conflict resolution.
8eef5d2cc850 in Bug 1300654 incorrectly resolved a merge conflict and backed
out part of the fix for Bug 1280829. Relanding.

MozReview-Commit-ID: 6DIkUrc9R4t
Comment on attachment 8797850 [details] [diff] [review]
Fixup bad merge conflict resolution from Bug 1300654/8eef5d2cc850

Approval Request Comment
[Feature/regressing bug #]: The build was broken on Aurora with the landing of bug 1299694. The fix for that is in bug 1300654, however that had a mismerge, so we also need this patch to fix the mismerge.
[User impact if declined]: Some videos which setup EME but don't actually use EME will not play.
[Describe test coverage new/current, TreeHerder]: We have a specific test to test this case, it's currently on aurroa.
[Risks and why]: Low, fixing a bad merge.
[String/UUID change made/needed]: None.
Attachment #8797850 - Flags: approval-mozilla-aurora?
Comment on attachment 8797850 [details] [diff] [review]
Fixup bad merge conflict resolution from Bug 1300654/8eef5d2cc850

Fix a bad merge conflict. Take it in 51 aurora.
Attachment #8797850 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/ff26deb40798
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Version: unspecified → 51 Branch
This issue is verified fixed on latest Nightly/Aurora builds from 2016-10-10 on the following OSes:
- Windows 7 x64
- Ubuntu 16.04 x64 LTS
- Mac OS X 10.11.6
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.