Closed Bug 1307622 Opened 8 years ago Closed 8 years ago

"error: commit.eslint hook raised an exception: 'line'"

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox50 fixed, firefox51 fixed, firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

Bug 1307622: Fix handling of ignored file warnings.
58 bytes, text/x-review-board-request
mossop
: review+
Details 
The hook fails with this error whenever a commit changes a file which matches an ignore pattern.
Comment on attachment 8797805 [details]
Bug 1307622: Fix handling of ignored file warnings.

https://reviewboard.mozilla.org/r/83410/#review81960

That was always going to be flakey :(
Attachment #8797805 - Flags: review?(dtownsend) → review+
Comment on attachment 8797805 [details]
Bug 1307622: Fix handling of ignored file warnings.

https://reviewboard.mozilla.org/r/83410/#review81960

Yeah, that's why I the check for the line property. At least if the message changes again, it won't fail with an incomprehensible error message.
https://hg.mozilla.org/mozilla-central/rev/1a95e8559eeb
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Testing → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: