1307688 - Intermittent dom/plugins/test/mochitest/test_hangui.xul | application crashed [@ nsTimerImpl::Fire()]

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=5156733&repo=mozilla-central

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win32/1475626860/mozilla-central_win7_ix_test-mochitest-other-bm119-tests1-windows-build3.txt.gz

Comment 1

[Benjamin Smedberg]

This is a EXCEPTION_ACCESS_VIOLATION_READ in nsTimerImpl::Fire with nothing particularly plugin-like on the stack. Nathan any recent changes to timers that might be related? And should be move this to XPCOM or leave it in plugins to die?

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #1)
> This is a EXCEPTION_ACCESS_VIOLATION_READ in nsTimerImpl::Fire with nothing
> particularly plugin-like on the stack. Nathan any recent changes to timers
> that might be related? And should be move this to XPCOM or leave it in
> plugins to die?

Byron fixed some TSan races in bug 1157323 that have a bit of fallout; this intermittent is probably related.  Byron, does this look related to bug 1307350?

Comment 3

[Byron Campen [:bwc]]

I have seen this in crash-stats too; I'm pretty sure this is due to something either rescheduling or cancelling timers from the wrong thread. I fear that we will be forced to add thread-checking to the timer API to detect this kind of misuse...

Comment 4

[Byron Campen [:bwc]]

I might be able to make the race condition less frequent when Cancel or Init happens somewhere other than the target thread, but actually fixing this is probably going to involve fixing one or both of bug 1285384 and bug 1290894.