Closed Bug 1307699 Opened 8 years ago Closed 8 years ago

Move some code to SeekingState

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:

Component:

Type:

defect

Priority:

P3

Severity:

normal

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla52

Tracking Flags:

Tracking

Status

firefox52

---

fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(9 files)

Bug 1307699. Part 1 - move OnSeekTaskResolved/OnSeekTaskRejected into SeekingState. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1307699. Part 2 - move mSeekTaskRequest into SeekingState. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1307699. Part 3 - move SeekCompleted() into SeekingState. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1307699. Part 4 - move DiscardSeekTaskIfExist() into the exit action of SeekingState. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1307699. Part 5 - move mSeekTask into SeekingState. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1307699. Part 6 - remove comments that are no longer valid. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1307699. Part 7 - remove null-checks for mSeekTask which is guaranteed to be non-null by Enter(). 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1307699. Part 8 - move mCurrentSeek into SeekingState. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1307699. Part 9 - replace mCurrentSeek with mSeekJob. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	kaku : review+	Details

JW Wang [:jwwang] [:jw_wang]

Assignee

Description

•

8 years ago

      No description provided.

JW Wang [:jwwang] [:jw_wang]

Assignee

Updated

•

8 years ago

Assignee: nobody → jwwang

Blocks: 1295892

Priority: -- → P3

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/83782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83782/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/83784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83784/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/83786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83786/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/83788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83788/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/83790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83790/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/83792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83792/

Comment hidden (mozreview-request)

Also we don't nullify mSeekTask in Exit() because the state object will be deleted soon after Exit().

Review commit: https://reviewboard.mozilla.org/r/83794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83794/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/83796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83796/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/83798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83798/

JW Wang [:jwwang] [:jw_wang]

Assignee

Updated

•

8 years ago

Attachment #8798272 - Flags: review?(kaku)

Attachment #8798273 - Flags: review?(kaku)

Attachment #8798274 - Flags: review?(kaku)

Attachment #8798275 - Flags: review?(kaku)

Attachment #8798276 - Flags: review?(kaku)

Attachment #8798277 - Flags: review?(kaku)

Attachment #8798278 - Flags: review?(kaku)

Attachment #8798279 - Flags: review?(kaku)

Attachment #8798280 - Flags: review?(kaku)

Tzuhao Kuo [:kaku]

Comment 10

•

8 years ago

mozreview-review

Comment on attachment 8798272 [details]
Bug 1307699. Part 1 - move OnSeekTaskResolved/OnSeekTaskRejected into SeekingState.

https://reviewboard.mozilla.org/r/83782/#review82360

::: dom/media/MediaDecoderStateMachine.cpp:741
(Diff revision 1)
>      mMaster->mCurrentSeek = Move(mSeekJob);
>    }
>  
> +  void Exit() override
> +  {
> +    mMaster->mSeekTaskRequest.DisconnectIfExists();

Attachment #8798272 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 11

•

8 years ago

mozreview-review

Comment on attachment 8798273 [details]
Bug 1307699. Part 2 - move mSeekTaskRequest into SeekingState.

https://reviewboard.mozilla.org/r/83784/#review82366

Attachment #8798273 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 12

•

8 years ago

mozreview-review

Comment on attachment 8798274 [details]
Bug 1307699. Part 3 - move SeekCompleted() into SeekingState.

https://reviewboard.mozilla.org/r/83786/#review82368

Attachment #8798274 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 13

•

8 years ago

mozreview-review

Comment on attachment 8798275 [details]
Bug 1307699. Part 4 - move DiscardSeekTaskIfExist() into the exit action of SeekingState.

https://reviewboard.mozilla.org/r/83788/#review82370

Attachment #8798275 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 14

•

8 years ago

mozreview-review

Comment on attachment 8798276 [details]
Bug 1307699. Part 5 - move mSeekTask into SeekingState.

https://reviewboard.mozilla.org/r/83790/#review82372

Attachment #8798276 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 15

•

8 years ago

mozreview-review

Comment on attachment 8798277 [details]
Bug 1307699. Part 6 - remove comments that are no longer valid.

https://reviewboard.mozilla.org/r/83792/#review82374

Attachment #8798277 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 16

•

8 years ago

mozreview-review

Comment on attachment 8798278 [details]
Bug 1307699. Part 7 - remove null-checks for mSeekTask which is guaranteed to be non-null by Enter().

https://reviewboard.mozilla.org/r/83794/#review82376

Attachment #8798278 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 17

•

8 years ago

mozreview-review

Comment on attachment 8798279 [details]
Bug 1307699. Part 8 - move mCurrentSeek into SeekingState.

https://reviewboard.mozilla.org/r/83796/#review82378

Attachment #8798279 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 18

•

8 years ago

mozreview-review

Comment on attachment 8798280 [details]
Bug 1307699. Part 9 - replace mCurrentSeek with mSeekJob.

https://reviewboard.mozilla.org/r/83798/#review82380

Attachment #8798280 - Flags: review?(kaku) → review+

JW Wang [:jwwang] [:jw_wang]

Assignee

Comment 19

•

8 years ago

Thanks for the review!

Comment 20

•

8 years ago

Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40e0bf77a61f
Part 1 - move OnSeekTaskResolved/OnSeekTaskRejected into SeekingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/262a8127caf3
Part 2 - move mSeekTaskRequest into SeekingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/3e9d1b093765
Part 3 - move SeekCompleted() into SeekingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/20fd2699fc8b
Part 4 - move DiscardSeekTaskIfExist() into the exit action of SeekingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/88c64b02985d
Part 5 - move mSeekTask into SeekingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/af8fa261dc62
Part 6 - remove comments that are no longer valid. r=kaku
https://hg.mozilla.org/integration/autoland/rev/33c45f3ea581
Part 7 - remove null-checks for mSeekTask which is guaranteed to be non-null by Enter(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/5291cf897999
Part 8 - move mCurrentSeek into SeekingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/209e990beeae
Part 9 - replace mCurrentSeek with mSeekJob. r=kaku

Carsten Book [:Tomcat]

Comment 21

•

8 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/40e0bf77a61f
https://hg.mozilla.org/mozilla-central/rev/262a8127caf3
https://hg.mozilla.org/mozilla-central/rev/3e9d1b093765
https://hg.mozilla.org/mozilla-central/rev/20fd2699fc8b
https://hg.mozilla.org/mozilla-central/rev/88c64b02985d
https://hg.mozilla.org/mozilla-central/rev/af8fa261dc62
https://hg.mozilla.org/mozilla-central/rev/33c45f3ea581
https://hg.mozilla.org/mozilla-central/rev/5291cf897999
https://hg.mozilla.org/mozilla-central/rev/209e990beeae

Status: NEW → RESOLVED

Closed: 8 years ago

status-firefox52: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla52

You need to log in before you can comment on or make changes to this bug.