1307745 - Custom video controls are no longer visible after Fullscreen API unprefixed

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Julian]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161004004006

Steps to reproduce:

I've defined the z-index CSS property with the value 2147483647 for custom video controls in the fullscreen mode.


Actual results:

In the latest 51.0a2 the controls are hidden.


Expected results:

In previous FF versions this works (tested with FF 45, 47 & 49). They should be visible.

Comment 1

[Loic]

Could you provide a simple testcase, please.

Comment 2

[Julian]

Attachment: test.html

This file demonstrates the issue. Just click on the red area.

Comment 3

[Loic]

Attachment: fullscreenff49-win7.jpg

I tested with FF49 on Win 7, I see no video controls with/without fullscreen.

Any idea why?

Comment 4

[Julian]

(In reply to Loic from comment #3)
> Created attachment 8798154 [details]
> fullscreenff49-win7.jpg
> 
> I tested with FF49 on Win 7, I see no video controls with/without fullscreen.
> 
> Any idea why?
According to your screenshot you actually see the controls. I haven't implemented them in the demo to make it minimalistic, but the red area would be the controls container. Just click on it like the text indicates.

Comment 5

[Loic]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=eda42451649ddd290b93ac3a8b248dc7c3ae83e5&tochange=6c07ed7d69124c3ff846dab68b96aad907a433d6

Xidorn, could you look at this issue, please. Or NI? someone else from the Layout team.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

You always need to request fullscreen on the container rather than the video element if you want to show the custom video conttols. Fullscreen element is always on the very top of the rendering stack (called top layer), above any other element regardless of their z-index. It is the expected behavior, and you would see the same behavior in every browser when they unprefix the Fullscreen API.

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

And Firefox doesn't unprefix the Fullscreen API in the release versions yet. Edge has disabled unprefixed Fullscreen API as well. Chrome is trying hard to catch up the spec and it is expected that we will coordinate unprefixing once Chrome finishes that.

Comment 8

[Julian]

(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #7)
> And Firefox doesn't unprefix the Fullscreen API in the release versions yet.

This was the important change. In previous releases Firefox it is necessary to call "mozRequestFullScreen" and since 51 it is "requestFullscreen". Thanks for this hint.

But I don't find this information in the changelog:
https://developer.mozilla.org/en-US/Firefox/Releases/51

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

Fullscreen API has been unprefixed for a while in Developer Edition. It was since Firefox 47 [1], and thus there is nothing to mention for Firefox 51.

Firefox 49 and 50 do not have unprefixed Fullscreen API because they are currently on release channels (beta and release). We have pretty different settings for release channels and non-release channels. If you download Firefox 50 Developer Edition (several weeks ago), you would see that it also has unprefixed Fullscreen API.


[1] https://developer.mozilla.org/en-US/Firefox/Releases/47#Others