Pressing volume down shows tab history panel

VERIFIED FIXED in Firefox 50

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: sebastian, Assigned: ahunt)

Tracking

(Blocks: 1 bug, {regression})

unspecified
Firefox 52
All
Android
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 unaffected, fennec50+, firefox50+ verified, firefox51+ verified, firefox52+ verified)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

I assume this is a regression from bug 1304688: When pressing the hardware volume down button the tab history panel shows up (Nexus 6P, Android 7.0).
@ahunt: Are you seeing this too?
Flags: needinfo?(ahunt)
(Assignee)

Comment 2

a year ago
(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> @ahunt: Are you seeing this too?

Yes.

And I realise now that I forgot to test that it's the back key that's being pressed in onKeyDown() : /.
Assignee: nobody → ahunt
Flags: needinfo?(ahunt)
Priority: -- → P1
Whiteboard: [MobileAS]
(Assignee)

Comment 3

a year ago
I filed Bug 1307836 to add tests for this, but I'm not sure how feasible adding tests actually is (we'd need to setup emulators for multiple android versions...).

With my patch (see next comment), I've confirmed that both on an Android 7 (N) and an Android 4.4 device:
- Single press back button works as expected
- Long press shows history
- Pressing volume up / down dowsn't show history
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Blocks: 1307836
(Assignee)

Comment 5

a year ago
[Tracking Requested - why for this release]: Regression introduced in Bug 1304688, affects all Android 7 devices: we'll show the history panel for all button presses (primarily volume down/up).
tracking-firefox50: --- → ?
tracking-firefox51: --- → ?
Comment on attachment 8798130 [details]
Bug 1307779 - Only start long-press timer for back button

https://reviewboard.mozilla.org/r/83676/#review82242
Attachment #8798130 - Flags: review?(s.kaspari) → review+
tracking-fennec: --- → ?
status-firefox49: --- → unaffected
status-firefox50: --- → affected
status-firefox51: --- → affected
status-firefox52: --- → affected
tracking-firefox52: --- → ?
tracking-fennec: ? → 50+

Comment 7

a year ago
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23b4707ed4f9
Only start long-press timer for back button r=sebastian
Tracking because it is a new regression which never shipped to our users.

Andrzej, Could you fill the uplift request? Thanks
tracking-firefox50: ? → +
tracking-firefox51: ? → +
tracking-firefox52: ? → +
Flags: needinfo?(ahunt)
Keywords: regression

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/23b4707ed4f9
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Can you request uplift for the release channels we uplifted the patch in bug 1304688 to?
(Assignee)

Comment 11

a year ago
Comment on attachment 8798130 [details]
Bug 1307779 - Only start long-press timer for back button

Approval Request Comment
[Feature/regressing bug #]: Bug 1304688 introduced this regression, while trying to work around an Android 7 system bug.
[User impact if declined]: Only on Android 7: pressing volume up/down (or any other hardware button other than the back button) results in the tab-history panel being shown after a ~3s delay.
[Describe test coverage new/current, TreeHerder]: manual testing on nightly, on both older (Android <=6) and newer (Android 7) devices.
[Risks and why]: Low risk: an additional condition has been added to the test for starting the backpress timer, this ensures that we only start the timer for the back button (but not other buttons).
[String/UUID change made/needed]: none.
Flags: needinfo?(ahunt)
Attachment #8798130 - Flags: approval-mozilla-beta?
Attachment #8798130 - Flags: approval-mozilla-aurora?
Comment on attachment 8798130 [details]
Bug 1307779 - Only start long-press timer for back button

Fixes a new regression in 50, Aurora51+, Beta50+
Attachment #8798130 - Flags: approval-mozilla-beta?
Attachment #8798130 - Flags: approval-mozilla-beta+
Attachment #8798130 - Flags: approval-mozilla-aurora?
Attachment #8798130 - Flags: approval-mozilla-aurora+

Comment 13

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/637b73dad0ae
status-firefox51: affected → fixed

Comment 14

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/c8c31aad61a1
status-firefox50: affected → fixed

Comment 15

a year ago
Verified this on Nexus 6P(Android 7.0) on Firefox 50 Beta, latest Aurora and latest Nightly
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
status-firefox51: fixed → verified
status-firefox52: fixed → verified
Iteration: --- → 1.6
You need to log in before you can comment on or make changes to this bug.