Closed Bug 1307793 Opened 3 years ago Closed 3 years ago

Pressing space during incremental find in menulist opens menu

Categories

(Core :: XUL, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

Details

Attachments

(1 file)

1. Focus a menulist but don't open it. One of the items in the list should have a space within its label.
2. Start typing the letters in that item's label.

Expected: The item should become selected.
Actual: The popup opens.

For example, focus a type 'One Th'. The second item should be selected and the dropdown should not open:

<menulist>
  <menupopup>
    <menuitem label="One Two"/>
    <menuitem label="One Three"/>
  </menupopup>
</menulist>

You can see this issue with some of the menulist dropdowns in Preferences, for example, 'When Firefox Starts' or the fonts setting.
 
This is Mac only.
Assignee: nobody → enndeakin
Attachment #8798046 - Flags: review?(ksteuber)
Comment on attachment 8798046 [details] [diff] [review]
Ignore space while incremental typing in menulist

Review of attachment 8798046 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8798046 - Flags: review?(ksteuber) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e7d76af9638e5a34c9153ed3b140622820a8b71
Bug 1307793, pressing space when menulist is ofocused should perform incremental find select rather than open the menu, r=ksteuber
https://hg.mozilla.org/mozilla-central/rev/8e7d76af9638
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: XP Toolkit/Widgets: Menus → XUL
You need to log in before you can comment on or make changes to this bug.