1307796 - Add Custom Field Form is Ugly

Status: NEW

(Bugzilla :: User Interface, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

Attachment: screenshot

Navigate to /editfields.cgi?action=add


It will look like the attached. I don't think admin UI needs to be pretty,
but this is really unusable.

The templates for custom fields are overly engineered. I *think*
the main stuff is in https://github.com/bugzilla/bugzilla/blob/master/template/en/default/admin/custom_fields/edit-common.html.tmpl

It would also be acceptable to completely redo this form
starting from https://github.com/bugzilla/bugzilla/blob/master/template/en/default/admin/custom_fields/create.html.tmpl

Comment 1

[Frédéric Buclin]

"this is really unusable" how? It's pretty easy to create a new custom field from the current UI. You don't even comment on what is difficult exactly.

Comment 2

[Anamika_07]

Attachment: UI_FORM

the icon image is not visible

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8799653 [details] [diff] [review]
UI_FORM

Review of attachment 8799653 [details] [diff] [review]:
-----------------------------------------------------------------

This won't work, because we can't write a full html document here. CSS will go into various files,
probably skins/global.css or similar.

Comment 4

[Anamika_07]

Attachment: Custom Form

Head header is not working. Made the required CSS file

Comment 5

[Anamika_07]

Attachment: .css file

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8800143 [details] [diff] [review]
Custom Form

per discussion earlier this morning.

Comment 7

[Anamika_07]

Attachment: Custom Form

Comment 8

[Anamika_07]

Attachment: Custom Form

Comment 9

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8803228 [details] [diff] [review]
Custom Form

Review of attachment 8803228 [details] [diff] [review]:
-----------------------------------------------------------------

The styling is going in the right direction, but it looks like not all the fields made it when you removed
the tables.

::: Bugzilla/Constants.pm
@@ +235,5 @@
>  # run-time, to reduce the number of requests required to render a page.
>  # Setting this to a false value can help debugging.
> +#use constant CONCATENATE_ASSETS => $ENV{PLACK_ENV} ? $ENV{PLACK_ENV} ne "development" : 0;
> +
> +use constant CONCATENATE_ASSETS => 0; #change made

This can go now, since we fixed bug 1309884

::: app.psgi
@@ +37,5 @@
>      skins
>  );
>  
> +if (Bugzilla::Constants::CONCATENATE_ASSETS) { warn "asset concat on" }
> +

remove this debugging code too

::: skins/standard/global.css
@@ +1615,4 @@
>      background-repeat: no-repeat !important;
>      background-position: right 8px center !important;
>  }
> +

remove this empty line

::: template/en/default/admin/custom_fields/create.html.tmpl
@@ +50,3 @@
>    <input type="hidden" name="action" value="new">
>    <input type="hidden" name="token" value="[% token FILTER html %]">
> +  <input type="submit" id="create" value="Create" style = "margin-left : 35%; width : 150px;">

nit: you should move this style into the CSS.

#create {
    margin-left: 35%;
    width: 150px;
}

::: template/en/default/admin/custom_fields/edit-common.html.tmpl
@@ +1,2 @@
> +
> +

Remove these two empty lines

@@ -34,5 @@
> -  </tr>
> -
> -  <tr>
> -    <th><label for="desc">Description:</label></th>
> -    <td>

looks like you accidentally removed some fields, like enter_bug here

@@ -46,5 @@
> -    <td>
> -      <input type="checkbox" id="new_bugmail" name="new_bugmail" value="1"
> -             [%- " checked" IF field.mailhead %]>
> -    </td>
> -  </tr>

and new_bugmail

@@ -69,5 @@
> -      <input type="checkbox" id="obsolete" name="obsolete" value="1"
> -             [%- " checked" IF field.obsolete %]>
> -    </td>
> -  </tr>
> -

this one too

::: template/en/default/global/header.html.tmpl
@@ +113,4 @@
>      [% END %]
>  
>      [% SET css_sets = css_files(style_urls, yui, yui_css) %]
> +    <!-- CONCAT ASSETS: [% constants.CONCATENATE_ASSETS %] --> 

remove debugging code

Comment 10

[Anamika_07]

Attachment: file3.patch

New Patch for Custom Field

Comment 11

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8804824 [details] [diff] [review]
file3.patch

This is still missing fields; I sent a sketch of what the HTML should be like. I think the CSS is getting close.

Comment 12

[Anamika_07]

Attachment: Added missing fields

Comment 13

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8807436 [details] [diff] [review]
Added missing fields

Review of attachment 8807436 [details] [diff] [review]:
-----------------------------------------------------------------

r-, it's missing a field fields and has whitespace nits. We'll discuss it further after we get your dev env re-setup.