1307907 - Add support for console.dirxml()

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P2)

Description

[Lin Clark [:linclark]]

Originally posted by:linclark

see https://github.com/devtools-html/gecko-dev/issues/243

This just acts like console.log, so we should be able to just create a console.log ConsoleMessage when one comes in.

Tests:
- [ ] browser_webconsole_bug_922212_console_dirxml.js (we can edit this down to one test case)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1307907 - Add support for console.dirxml() in the new console frontend. ;

Adds console.dirxml support, which behave the same as console.log.
Adds mocha test to ensure dirxml calls are rendered as expected.

Review commit: https://reviewboard.mozilla.org/r/84214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84214/

Comment 2

[Lin Clark [:linclark]]

Comment on attachment 8798829 [details]
Bug 1307907 - Add support for console.dirxml() in the new console frontend. ;

https://reviewboard.mozilla.org/r/84214/#review82812

Comment 3

[Lin Clark [:linclark]]

This looks good to me! Feel free to land at will.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8798829 [details]
Bug 1307907 - Add support for console.dirxml() in the new console frontend. ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84214/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0adc3b879367
Add support for console.dirxml() in the new console frontend. r=linclark;

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0adc3b879367