1307972 - Fix parent process leaks when using the GPU process

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

When I enable the GPU process on treeherder, many columns are orange due to a UI process leak. It looks like we NS_DispatchToMainThread after xpcom-shutdown which leaks a runnable.

This patch fixes the leak by shutting down the Vsync I/O thread on xpcom shutdown, rather than when the GPUProcessManager singleton is destroyed. I also added a bunch of missing MOZ_COUNT_CTORs.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8798199 [details] [diff] [review]
fix

Review of attachment 8798199 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/VsyncBridgeChild.cpp
@@ +14,5 @@
>   : mThread(aThread),
>     mLoop(nullptr),
>     mProcessToken(aProcessToken)
>  {
> +  MOZ_COUNT_CTOR(VsyncBridgeChild);

Don't need this. PVsyncBridgeChild already does it.

@@ +19,5 @@
>  }
>  
>  VsyncBridgeChild::~VsyncBridgeChild()
>  {
> +  MOZ_COUNT_DTOR(VsyncBridgeChild);

Same.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01fd505d5cc2
Fix parent process leaks when using the GPU process. (bug 1307972, r=billm)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01fd505d5cc2