Closed Bug 1308029 Opened 6 years ago Closed 6 years ago

Resolve Javadoc build issues

Categories

(JSS Graveyard :: Documentation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: elio.maldonado.batiz, Assigned: edewata)

References

Details

Attachments

(3 files, 2 obsolete files)

No description provided.
Attached patch Resolves Javadoc build issue(s) (obsolete) — Splinter Review
Downstream patch by Endi Sukma Dewata, not ready yet for reviw
Attached patch Resolve -javadoc build issues (obsolete) — Splinter Review
Regenerated - 31/31 tests pass.
Attachment #8798970 - Attachment is obsolete: true
Assignee: glenbeasley → edewata
Depends on: 1308027
Comment on attachment 8835283 [details] [diff] [review]
Resolve -javadoc build issues

Review of attachment 8835283 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thanks!
Attachment #8835283 - Flags: review+
Modified on account of latest upstream sources by Elio.
Attachment #8835283 - Attachment is obsolete: true
Attachment #8845724 - Flags: review?(jmagne)
Comment on attachment 8845724 [details] [diff] [review]
Resolve -javadoc build issues

Observed the careful merging and comparison of this patch against the original. Builds fine.
Attachment #8845724 - Flags: review?(jmagne) → review+
Pushed: https://hg.mozilla.org/projects/jss/rev/d08ff605a69000f63c64f135e12a7012a8c85650
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Historical Note:
# RHBZ 1289799 - Resolve Javadoc build issue(s)
# https://bugzilla.redhat.com/show_bug.cgi?id=1289799
# author: edewata@redhat.com
# Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1308029
Patch34:        jss-javadoc-fixes.patch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fixes build bustage found downstream while using the latest source in preparation for and upcoming rebase.
Attachment #8846327 - Flags: review?(mharmsen)
Comment on attachment 8846327 [details] [diff] [review]
Fix paramater name as in javadoc comment

ACK - fixed typo
Attachment #8846327 - Flags: review?(mharmsen) → review+
Pushed: https://hg.mozilla.org/projects/jss/rev/b1c6660e7e71e508b803be319eb143d28ee13aff
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Get rid rid of code fragment that I forgot to remove. Needed for our integration testing to pass.
Attachment #8846748 - Flags: review?(edewata)
Attachment #8846748 - Flags: review?(edewata) → review+
The patch in comment #11 is actually for bug #1308026.
Target Milestone: --- → 4.4
You need to log in before you can comment on or make changes to this bug.