1308083 - Repair or remove "fix it" hyperlink

Status: RESOLVED FIXED

(SeaMonkey :: Website, defect)

Description

[Rainer Bielefeld]

On "Get Involved with SeaMonkey" you find "fix it" with a link to <http://www.mozilla.org/developer/> behind it. 
Instead of useful hints I see a localized "Not Found" hint.

I haven't a clue whether there is a successor for <http://www.mozilla.org/developer/>. Vanished contents might be somewhere in the area of 
<http://www-archive.mozilla.org/contribute/>
<http://www-archive.mozilla.org/developer/>

NEW due to Bug 1224107 comment #3

Comment 1

[Kohei Yoshino [:kohei]]

http://web.archive.org/web/20120503231604/http://www.mozilla.org/developer/

So http://www.mozilla.org/developer/ could be linked to https://developer.mozilla.org/docs/Mozilla/Developer_guide

But the "fix it" link on the Get Involved with SeaMonkey page could be simply linked to http://www.seamonkey-project.org/dev/

Comment 2

[Mayank Chauhan]

Hi,

Can anyone assign this thing to me? I am looking for my first contribution.

Thanks
Mayank Chauhan

Comment 3

[Rainer Bielefeld]

No need to assign, you can simply start. I will send some hints by private mail

Comment 4

[Mayank Chauhan]

How I can get the code of the SeaMonkey site? So I can apply, what is written in comment #1.

Comment 5

[Mayank Chauhan]

Attachment: Fixed the broken link, by replacing with correct one

On "Get Involved with SeaMonkey" these is "fix it" with a link to http://www.mozilla.org/developer/ . 

Now, that link no longer exist. The correct link is
http://www.seamonkey-project.org/dev/ .

The link is now fixed.

Comment 6

[Rainer Bielefeld]

Comment on attachment 8821564 [details] [diff] [review]
Fixed the broken link, by replacing with correct one

I am not a developer and not a reviewer.

Feedback: <http://www.seamonkey-project.org/dev/> is a vaild link, but I would prefer Kohei Yoshino's suggestion of a direct link to <https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide> instead of detour to general overview "seamonkey-project.org/dev/", where .../Developer_guide also is linked.

@Jens: I read that you do not want to be reviewer in future. Is there any way to switch off BZ suggestion for "[e-mail]"?

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8821564 [details] [diff] [review]
Fixed the broken link, by replacing with correct one

I set the review? to IanN. Usually he or Philip Chee handle the reviews.

I agree with Rainer. Its likely you already came from the page which you now link to. I would put the Mzilla url in.

For an additional enhancement I would also add a small explanation together with the link. Clicking on fix it and redirecting to a generic dev page is a little bland. 

FRG

Comment 8

[Mayank Chauhan]

@Frank-Rainer Grahl

I have made the changes, as you wished. Is the fine now?

Comment 9

[Mayank Chauhan]

Attachment: Replaced the wrong link in fix it with new link

Comment 10

[Rainer Bielefeld]

Assignee due to facts

Comment 11

[Ian Neal]

Comment on attachment 8821711 [details] [diff] [review]
Replaced the wrong link in fix it with new link

Not sure where you are getting the source file from. According to https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/file/tip/src/dev/get-involved.en.html#l67 it doesn't seem to be the same version.

Did you use https://hg.mozilla.org/SeaMonkey/seamonkey-project-org  ?

Whilst you are here could you remove the extra space from the line above?

f=me for the moment as need new patch against correct source.

Comment 12

[Mayank Chauhan]

(In reply to Ian Neal from comment #11)
> Comment on attachment 8821711 [details] [diff] [review]
> Replaced the wrong link in fix it with new link
> 
> Not sure where you are getting the source file from. According to
> https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/file/tip/src/dev/get-
> involved.en.html#l67 it doesn't seem to be the same version.
> 
> Did you use https://hg.mozilla.org/SeaMonkey/seamonkey-project-org  ?
> 
> Whilst you are here could you remove the extra space from the line above?
> 
> f=me for the moment as need new patch against correct source.

Yea, I have used that url, to clone the project. I don't know why the version mis-match occured. I think I missed the rebase command, before making the patch.

I will remove the extra space above that line.

Comment 13

[Mayank Chauhan]

@Ian Neal 
Could you tell me why the current patch doesn't works?

Comment 14

[Ian Neal]

(In reply to Mayank Chauhan from comment #13)
> @Ian Neal 
> Could you tell me why the current patch doesn't works?

It looks like you did not back out your first patch, so the second patch was based off code including your first patch.

Comment 15

[Rainer Bielefeld]

@Mayank Chauhan
It seems Ian's explication was not useful for you?

Comment 16

[Philip Chee]

If you are using mercurial queues, you can use qfold to fold two patches together.

Comment 17

[George Veneel Dogga [::TheLayman]]

Attachment: V1.patch

Comment 18

[George Veneel Dogga [::TheLayman]]

Attachment: Proposed Patch

Ignore the previous patch. That was a mistake. 

Please review this and let me know. :)

Comment 19

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 8827974 [details] [diff] [review]
V1.patch

Sorry but I'm not doing reviews anymore.

Comment 20

[George Veneel Dogga [::TheLayman]]

Comment on attachment 8827978 [details] [diff] [review]
Proposed Patch

Proposed Patch

Comment 21

[Philip Chee]

Comment on attachment 8827978 [details] [diff] [review]
Proposed Patch

Looks good!

Comment 22

[Philip Chee]

Pushed to the SeaMonkey website repository:
> https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/bff6722f1761290322832ce642eea5dad8988f5c
Added patch author name to the changeset/patch