1308094 - Replace PL_strdup/PL_strfree with strdup / free

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P5)

Description

[Chris Peterson [:cpeterson]]

We want to replace NSPR functions with standard C functions if they available on all platforms. This bug is probably not a good-first-bug because there are some special cases to consider.

1. Replace PL_strdup() calls with strdup() outside of nsprpub/ and security/nss code:

https://searchfox.org/mozilla-central/search?q=PL_strdup&path=.cpp%24&case=false&regexp=false

*** CAUTION: PL_strdup(nullptr) will return "", but strdup(nullptr) will crash! Any calls to PL_strdup() that are changed to strdup() should be carefully audited to see if they might need to handle a null pointer, with code like strdup(str ? str : "") or maybe returning an error.

2. Replace PL_strfree() calls with free():

https://searchfox.org/mozilla-central/search?q=PL_strfree&path=.cpp%24&case=false&regexp=false

3. Add #include <string.h> if it's needed for strdup()'s function declaration.

4. Remove #include "plstr.h" if it's no longer needed for other NSPR string function declarations.

Comment 1

[Chris Peterson [:cpeterson]]

Waldo recommends using a safer Gecko string class or function instead of just swapping PL_strdup() for strdup().

Comment 2

[Nicklas Boman [:smurfd]]

Attachment: Bug 1308094 - Remove deprecated PL_strdup calls from toolkit code r=gijs

Comment 3

[Nicklas Boman [:smurfd]]

Attachment: Bug 1308094 - Remove PL_strdup and PL_strfree from BloatEntry r=#xpcom-reviewers,mccr8

Depends on D122148

Comment 4

[Nicklas Boman [:smurfd]]

Attachment: Bug 1308094 - Remove deprecated PL_strdup and PL_strfree calls from modules code r=valentin

Depends on D122149

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48be7a726d32
Remove deprecated PL_strdup calls from toolkit code r=Gijs
https://hg.mozilla.org/integration/autoland/rev/da16c4f3a988
Remove PL_strdup and PL_strfree from BloatEntry r=xpcom-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/ada63ac5146d
Remove deprecated PL_strdup and PL_strfree calls from modules code r=valentin

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/48be7a726d32
https://hg.mozilla.org/mozilla-central/rev/da16c4f3a988
https://hg.mozilla.org/mozilla-central/rev/ada63ac5146d