1308099 - Rename AnimationPhase::Null to AnimationPhase::Idle.

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Mantaroh Yoshinaga[:mantaroh]]

Web Animation spec defines the idle phase.[1]

[1] https://w3c.github.io/web-animations/#idle-phase

This phase is sames as AnimationPhase::Null of gecko.
So we will need to change to the name for consistency.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

I'm changing the code related AniamtionPhase::Null in bug 1202333.
So this bug will need to land after bug 1202333.

WIP Code: https://treeherder.mozilla.org/#/jobs?repo=try&revision=af77c5af563ea9bb47660d7f9ba63159909428c0

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1308099 part 1 - Rename AnimationPhase::Null to AnimationPhase::Idle.

In Web Animations specification, if the animation effect is in none of the any phase, it define as 'Idle' phase. [1]
But, in the gecko, it defined as 'Null' phase.

So we will need to use 'Idle' phase for consistency.

[1] https://w3c.github.io/web-animations/#idle-phase

Review commit: https://reviewboard.mozilla.org/r/107046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107046/

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

I need it before working on bug 1302648.

hiro, If you have a chance to see it, Would you please confirm this patch?

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8830147 [details]
Bug 1308099 part 1 - Rename AnimationPhase::Null to AnimationPhase::Idle.

https://reviewboard.mozilla.org/r/107046/#review108142

LGTM.

I just notice that 'typedef mozilla::ComputedTiming::AnimationPhase AnimationPhase' in nsTransitionManager.cpp is not useful. Also 'ComputedTiming::' at [1] can be dropped.

[1] https://hg.mozilla.org/mozilla-central/file/6dccae211ae5/layout/style/nsAnimationManager.cpp#l202

Let's drop them in a follow up patch.

Comment 5

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1308099 part 2 - Remove unnecessary typedef and use defined name instead of full namespace.

Review commit: https://reviewboard.mozilla.org/r/107048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107048/

Comment 6

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8830147 [details]
Bug 1308099 part 1 - Rename AnimationPhase::Null to AnimationPhase::Idle.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107046/diff/1-2/

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8830157 [details]
Bug 1308099 part 2 - Remove unnecessary typedef and use defined name instead of full namespace.

https://reviewboard.mozilla.org/r/107048/#review108154

Nice!

Comment 8

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8830157 [details]
Bug 1308099 part 2 - Remove unnecessary typedef and use defined name instead of full namespace.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107048/diff/1-2/

Comment 9

[Mantaroh Yoshinaga[:mantaroh]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #7)
> Comment on attachment 8830157 [details]
> Bug 1308099 part 2 -Remove unncessary typedef and use defined name instead
> of full namespace.
> 
> https://reviewboard.mozilla.org/r/107048/#review108154
> 
> Nice!

Thanks hiro!

I addressed commit comment typo. s/unncessary/unnecessary.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a74646daaac9dc0bf9028bcb2738d6127a1c42f0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28c59fd46b6f
part 1 - Rename AnimationPhase::Null to AnimationPhase::Idle. r=hiro
https://hg.mozilla.org/integration/autoland/rev/79595c80d0a0
part 2 - Remove unnecessary typedef and use defined name instead of full namespace. r=hiro

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/28c59fd46b6f
https://hg.mozilla.org/mozilla-central/rev/79595c80d0a0