Closed
Bug 1308119
Opened 8 years ago
Closed 8 years ago
Replace nsIAudioChannelAgent with AudioChannelAgent in MediaElement
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(1 file)
Since I want to use more agent's functions in MediaElement and I don't think these functions need to be exposed on IDL level. (for other languages binding) Therefore, I want to use AudioChannelAgent directly in MediaElement.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8798331 [details] Bug 1308119 - replace nsIAudioChannelAgent with AudioChannelAgent. https://reviewboard.mozilla.org/r/83858/#review82502 ::: dom/html/HTMLMediaElement.h:58 (Diff revision 1) > class TimeRanges; > class WakeLock; > class MediaTrack; > class MediaStreamTrack; > class VideoStreamTrack; > +class AudioChannelAgent; this list is not in alphabetic order, but let's put this AudiChannelAgent at the top. ::: dom/html/HTMLMediaElement.cpp:5722 (Diff revision 1) > { > VideoFrameContainer* container = GetVideoFrameContainer(); > return container ? container->GetImageContainer() : nullptr; > } > > bool void ::: dom/html/HTMLMediaElement.cpp:5723 (Diff revision 1) > VideoFrameContainer* container = GetVideoFrameContainer(); > return container ? container->GetImageContainer() : nullptr; > } > > bool > HTMLMediaElement::MaybeCreateAudioChannelAgent() and remove any check where we use MaybeCreateAudioChannelAgent()
Attachment #8798331 -
Flags: review?(amarchesini) → review+
Comment hidden (mozreview-request) |
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4333cfe24b9 replace nsIAudioChannelAgent with AudioChannelAgent. r=baku
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e4333cfe24b9
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•