Closed Bug 1308132 Opened 6 years ago Closed 6 years ago

Use std::unique_ptr instead of mozilla::UniquePtr as the underlying type for ScopedNSSTypes.h UniqueX types

Categories

(Core :: Security: PSM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

References

()

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

The UniqueX types defined in ScopedNSSTypes.h such as UniqueCERTCertificate currently use mozilla::UniquePtr as their underlying type. While this works fine, we should proactively move to std::unique_ptr instead so we can get hopefully eventually get rid of mozilla::UniquePtr.

std::unique_ptr at least compiles fine for all the platforms we care about:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a7daa5338134c1e589a7ddf3ec360e6ea5850f2
Comment on attachment 8798354 [details]
Bug 1308132 - Use std::unique_ptr instead of mozilla::UniquePtr as the underlying type for ScopedNSSTypes.h UniqueX types.

https://reviewboard.mozilla.org/r/83876/#review82418
Attachment #8798354 - Flags: review?(mgoodwin) → review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/acccbf8dc09c
Use std::unique_ptr instead of mozilla::UniquePtr as the underlying type for ScopedNSSTypes.h UniqueX types.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/acccbf8dc09c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.