1308143 - Clean up ExtendedValidation.cpp

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

ExtendedValidation.cpp is in need of some cleaning up.

Here's an incomplete list of what needs cleaning up:
1. These two defines don't appear to be used anywhere:
> #define CONST_OID static const unsigned char
> #define OI(x) { siDEROID, (unsigned char*) x, sizeof x }
2. nsMyTrustedEVInfo members use underscore_naming, instead of camelCase
3. Doesn't use the preferred PSM style of early returns
4. Contains some unnecessary "mozilla::" prefixes.
   4a. Some code is inside the mozilla::psm namespace, and some aren't. Ideally, they should all be within the same namespace.

Comment 1

[:Cykesiopka]

Attachment: Bug 1308143 - Clean up ExtendedValidation.cpp.

In general, the changes here attempt to:
1. Fix up the style to match modern PSM style.
2. Shorten unnecessarily long code.
3. Reduce global scope pollution.

Review commit: https://reviewboard.mozilla.org/r/137146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137146/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8865514 [details]
Bug 1308143 - Clean up ExtendedValidation.cpp.

https://reviewboard.mozilla.org/r/137146/#review140284

Cool - lgtm.

Comment 3

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1409a0bf3ca74860863ea0b6a660152644fe304

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cb5ee464e42
Clean up ExtendedValidation.cpp. r=keeler

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0b06894933d
Clean up ExtendedValidation.cpp. r=keeler

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0b06894933d