1308220 - TraceLogger: report calls

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Hannes Verschore [:h4writer]]

We have VM calls and also VMSpecific, but nothing similar for Calls. This bug is specific for calls to C++ code, since if we go to C++ code out of IonMonkey we want to know that!

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Add TraceLogger_Call

Comment 2

[Hannes Verschore [:h4writer]]

Todo: Add TraceLogger_CallSpecific

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8798434 [details] [diff] [review]
Add TraceLogger_Call

Review of attachment 8798434 [details] [diff] [review]:
-----------------------------------------------------------------

Moar tracelogger!

::: js/src/jit/CodeGenerator.cpp
@@ +3753,5 @@
>      // Move the StackPointer back to its original location, unwinding the native exit frame.
>      masm.adjustStack(NativeExitFrameLayout::Size() - unusedStack);
>      MOZ_ASSERT(masm.framePushed() == initialStack);
> +
> +    emitTracelogStopEvent(TraceLogger_Call);

Either this needs to be moved just before the branchIfFalseBool, or you need to duplicate it on the failure label path, right?

::: js/src/vm/TraceLoggingTypes.h
@@ +37,5 @@
>      _(Scripts)                                        \
>      _(VM)                                             \
>      _(CompressSource)                                 \
>      _(WasmCompilation)                                \
> +    _(Call)                                           \

Should this be enabled by default?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4bd4302355b
TraceLogger: generally report non-jit calls in ionmonkey, r=bbouvier

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c4bd4302355b