Closed Bug 1308234 Opened 4 years ago Closed 4 years ago

stylo: Fix types in Servo_ functions

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: manishearth, Assigned: manishearth)

References

Details

Attachments

(1 file)

Bug 1308234 - Fix signatures of Servo_ functions to match servo glue;
58 bytes, text/x-review-board-request
heycam
: review+
emilio
: review+
Details 
Found by the type assertions created in https://github.com/servo/servo/pull/13617
The Servo_* functions have it all wrong too, will fix in a bit
Comment on attachment 8798463 [details]
Bug 1308234 - Fix signatures of Servo_ functions to match servo glue;

https://reviewboard.mozilla.org/r/83948/#review82816

(Reviewing by Manish's request over IRC)

Looks good to me.

::: dom/base/nsINode.h:2086
(Diff revision 3)
>  #else
>      MOZ_CRASH("Accessing servo node data in non-stylo build");
>  #endif
>    }
>  
> -  void ClearServoData() {
> +  void ClearServoData();

This is kind of unfortunate, but since it's used only in a few places, I guess it's ok.
Attachment #8798463 - Flags: review+
Pushed by manishearth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cd474cbe2d13
Fix signatures of Servo_ functions to match servo glue; r=emilio
Comment on attachment 8798463 [details]
Bug 1308234 - Fix signatures of Servo_ functions to match servo glue;

https://reviewboard.mozilla.org/r/83948/#review83000

(Moot r+ since it's landed already.)
Attachment #8798463 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/cd474cbe2d13
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.