Closed
Bug 1308240
Opened 8 years ago
Closed 8 years ago
Typos in Collection.prototype.batch and Collection.prototype.commit getters
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: tcsc, Assigned: tcsc)
Details
Attachments
(1 file)
Noticed while working on download batching, but it doesn't seem appropriate to bundle as part of that patch. Currently, neither of these ever are called, and in fact, when initially authored they threw explicit errors, since you probably shouldn't be reading these properties. That said, if you do read them, they throw a ReferenceError (since they have `_commit` instead of `this._commit`, etc), which is bad. This is a trivial fix, patch incoming.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8798477 [details] Bug 1308240 - Fix missing `this.` in Sync's Collection's getters. https://reviewboard.mozilla.org/r/83960/#review82626 I still think throwing was a better choice ;)
Attachment #8798477 -
Flags: review?(markh) → review+
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8e1f5cf0a70 Fix missing `this.` in Sync's Collection's getters. r=markh
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d8e1f5cf0a70
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in
before you can comment on or make changes to this bug.
Description
•