1308263 - Add a grid display setting for extending the grid lines infinitely

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Adds a checkbox in Grid Display Settings to "Extend grid lines infinitely" and enables the showInfiniteLines for all CssGridHighlighters.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Part 1: Add a preference for extending lines infinitely in the grid highlighter.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7966a6adb3d61a2c2b495391f08f49ae035a645
Bug 1308263 - Part 1: Add a preference for extending lines infinitely in the grid highlighter. r=pbro

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Part 2: Add a grid highlighter setting PropType to manage the show infinite lines option and a method to update it. [1.0]

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a7966a6adb3d

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1308263-3.patch [WIP1]

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Part 3: Add a grid display setting for extending the grid lines infinitely. [1.0]

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Part 2: Add a grid highlighter setting PropType to manage the show infinite lines option and a method to update it. [2.0]

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8814724 [details] [diff] [review]
Part 2: Add a grid highlighter setting PropType to manage the show infinite lines option and a method to update it. [2.0]

Review of attachment 8814724 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.  This recent Twitter thread helped me think about the right boundaries for Redux actions, might be useful:

https://twitter.com/dan_abramov/status/800310164792414208

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8814723 [details] [diff] [review]
Part 3: Add a grid display setting for extending the grid lines infinitely. [1.0]

Review of attachment 8814723 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/inspector/layout/components/GridDisplaySettings.js
@@ +43,5 @@
> +        {},
> +        getStr("layout.gridDisplaySettings")
> +      ),
> +      dom.ul(
> +        {},

Can't remember if you have to pass these if empty?  Anyway, maybe you like them for consistent style?  Up to you.

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/664ac68c497e4a93a1fba73d2d9fb75b197aad7c
Bug 1308263 - Part 2: Add a grid highlighter setting PropType to manage the show infinite lines option and a method to update it. r=jryans

https://hg.mozilla.org/integration/mozilla-inbound/rev/49664db41b866ae46e185249ed61275fd1d94022
Bug 1308263 - Part 3: Add a grid display setting for extending the grid lines infinitely. r=jryans

Comment 11

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Part 4: Fix ESLint error in devtools/client/inspector/layout/types.js.

Comment 12

[Gabriel Luong [:gl] (ΦωΦ)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7bc1a0226b9c67ba55ba043e9a4a99546ff8f20e
Bug 1308263 - Part 4: Fix ESLint error in devtools/client/inspector/layout/types.js. r=me

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/664ac68c497e
https://hg.mozilla.org/mozilla-central/rev/49664db41b86
https://hg.mozilla.org/mozilla-central/rev/7bc1a0226b9c