Closed
Bug 1308263
Opened 5 years ago
Closed 4 years ago
Add a grid display setting for extending the grid lines infinitely
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(4 files, 2 obsolete files)
1.03 KB,
patch
|
pbro
:
review+
gl
:
checkin+
|
Details | Diff | Splinter Review |
12.50 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
5.23 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
718 bytes,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
Adds a checkbox in Grid Display Settings to "Extend grid lines infinitely" and enables the showInfiniteLines for all CssGridHighlighters.
Assignee | ||
Updated•5 years ago
|
Summary: Display a grid display setting for extending the grid lines infinitely → Add a grid display setting for extending the grid lines infinitely
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•4 years ago
|
||
Attachment #8814325 -
Flags: review?(pbrosset)
Updated•4 years ago
|
Attachment #8814325 -
Flags: review?(pbrosset) → review+
Assignee | ||
Updated•4 years ago
|
Keywords: leave-open
Assignee | ||
Comment 2•4 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7966a6adb3d61a2c2b495391f08f49ae035a645 Bug 1308263 - Part 1: Add a preference for extending lines infinitely in the grid highlighter. r=pbro
Assignee | ||
Comment 3•4 years ago
|
||
Attachment #8814528 -
Flags: review?(jryans)
Assignee | ||
Updated•4 years ago
|
Attachment #8814325 -
Flags: checkin+
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a7966a6adb3d
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Attachment #8814643 -
Attachment is obsolete: true
Attachment #8814723 -
Flags: review?(jryans)
Assignee | ||
Comment 7•4 years ago
|
||
Attachment #8814528 -
Attachment is obsolete: true
Attachment #8814528 -
Flags: review?(jryans)
Attachment #8814724 -
Flags: review?(jryans)
Comment on attachment 8814724 [details] [diff] [review] Part 2: Add a grid highlighter setting PropType to manage the show infinite lines option and a method to update it. [2.0] Review of attachment 8814724 [details] [diff] [review]: ----------------------------------------------------------------- Seems reasonable. This recent Twitter thread helped me think about the right boundaries for Redux actions, might be useful: https://twitter.com/dan_abramov/status/800310164792414208
Attachment #8814724 -
Flags: review?(jryans) → review+
Comment on attachment 8814723 [details] [diff] [review] Part 3: Add a grid display setting for extending the grid lines infinitely. [1.0] Review of attachment 8814723 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/inspector/layout/components/GridDisplaySettings.js @@ +43,5 @@ > + {}, > + getStr("layout.gridDisplaySettings") > + ), > + dom.ul( > + {}, Can't remember if you have to pass these if empty? Anyway, maybe you like them for consistent style? Up to you.
Attachment #8814723 -
Flags: review?(jryans) → review+
Assignee | ||
Updated•4 years ago
|
Keywords: leave-open
Assignee | ||
Comment 10•4 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/664ac68c497e4a93a1fba73d2d9fb75b197aad7c Bug 1308263 - Part 2: Add a grid highlighter setting PropType to manage the show infinite lines option and a method to update it. r=jryans https://hg.mozilla.org/integration/mozilla-inbound/rev/49664db41b866ae46e185249ed61275fd1d94022 Bug 1308263 - Part 3: Add a grid display setting for extending the grid lines infinitely. r=jryans
Assignee | ||
Comment 11•4 years ago
|
||
Attachment #8815233 -
Flags: review+
Assignee | ||
Comment 12•4 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7bc1a0226b9c67ba55ba043e9a4a99546ff8f20e Bug 1308263 - Part 4: Fix ESLint error in devtools/client/inspector/layout/types.js. r=me
Comment 13•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/664ac68c497e https://hg.mozilla.org/mozilla-central/rev/49664db41b86 https://hg.mozilla.org/mozilla-central/rev/7bc1a0226b9c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Updated•3 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•