Closed Bug 1308265 Opened 3 years ago Closed 3 years ago

Add a grid display setting for displaying the grid line numbers

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Adds a checkbox under Grid Display Settings to "Display numbers on lines" and enables the showGridLineNumbers option for all CssGridHighlighters.
Assignee: nobody → gl
Status: NEW → ASSIGNED
Attached patch 1308265.patchSplinter Review
Attachment #8814785 - Flags: review?(jryans)
Depends on: 1308263
Comment on attachment 8814785 [details] [diff] [review]
1308265.patch

Review of attachment 8814785 [details] [diff] [review]:
-----------------------------------------------------------------

I notice there are no tests so far...  Should you file a follow up to add some?
Attachment #8814785 - Flags: review?(jryans) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77eaeeade47e
Add a grid display setting for displaying the grid line numbers. r=jryans
https://hg.mozilla.org/integration/mozilla-inbound/rev/77eaeeade47ebbe695df5abb56f47bf4b57a9eaa
Bug 1308265 - Add a grid display setting for displaying the grid line numbers. r=jryans
https://hg.mozilla.org/mozilla-central/rev/77eaeeade47e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.