Closed
Bug 1308275
Opened 8 years ago
Closed 8 years ago
SOCKS socket does not support spaces and other special characters (Tor 20304)
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: mcs, Assigned: mcs)
References
Details
(Whiteboard: [tor][necko-active])
Attachments
(1 file, 1 obsolete file)
|
1.84 KB,
patch
|
xeonchen
:
review+
|
Details | Diff | Splinter Review |
Special characters, including spaces, are not decoded before the configured network.proxy.socks path is placed inside a Unix domain sockaddr. This causes the SOCKS connection to not work at all when a Unix domain socket is used with a path that contains spaces (or other URL-special characters). Corresponding Tor Browser bug report: https://trac.torproject.org/20304
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → xeonchen
|
||
Updated•8 years ago
|
Whiteboard: [tor]
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8798530 [details] [diff] [review] proposed fix Review of attachment 8798530 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for this patch. It looks good to me. Daniel, would you please help to review?
Attachment #8798530 -
Flags: review?(daniel)
|
||
Updated•8 years ago
|
Whiteboard: [tor] → [tor][necko-active]
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8798530 [details] [diff] [review] proposed fix Review of attachment 8798530 [details] [diff] [review]: ----------------------------------------------------------------- I approve!
Attachment #8798530 -
Flags: review?(daniel) → review+
|
|
||
Comment 4•8 years ago
|
||
rebase, carry r+
Attachment #8798530 -
Attachment is obsolete: true
Attachment #8801634 -
Flags: review+
|
|
||
Updated•8 years ago
|
Assignee: xeonchen → mcs
|
|
||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1ffc57f06b642c8e15a16d3127cbba7c47afefe
|
|
||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fd162c41b684 make unix domain socket support spaces; r=bagder
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fd162c41b684
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•