Closed Bug 1308291 Opened 8 years ago Closed 8 years ago

Edit Review dropdown dialog doesn't make it immediately clear how to dismiss it

Categories

(MozReview Graveyard :: Review Board: User Interface, defect)

Product:
MozReview Graveyard
Component:
Review Board: User Interface
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mconley, Assigned: davidwalsh)

References

Details

Attachments

(2 files)

Screenshot of the review edit dialog
118.57 KB, image/png
Details
MozReview: Provide close button for dropdown dialog (Bug 1308291).
58 bytes, text/x-review-board-request
glob
: review+
Details 
The Edit Review dropdown dialog was a heck of an improvement upon the full page dialog that was shown to users when they were finishing up a review.

However, having talked with jrmuizel, I suspect there's more that could be done to make it clear how this thing works.

See the attached screenshot.

Review Board is pretty box-y, and so this dialog, which is also a box, doesn't really distinguish itself from the surrounding boxes. So it's actually not immediately obvious from a glance that the dropdown is actually dropdown as opposed to part of the page that just appeared.

Because that relationship isn't clear, it's also not entirely clear that clicking on "Finished Edit" (which maybe should be "Finish Editing"?) dismisses the dialog. Once I told him that it was a dialog, jrmuizel started looking for an X to dismiss it.

So I think there might be room here to make it more obvious how this dialog relates to the rest of the page, and to the header.
Oh, "Finished Edit" can dismiss this dialog?!?!  I wish I knew that before, I have had to finish so many reviews with that giant thing in the middle of the screen!

I agree that an X button would have been much more obvious.
Attachment #8806824 - Flags: review?(glob)
Comment on attachment 8806824 [details]
MozReview: Provide close button for dropdown dialog (Bug 1308291).

https://reviewboard.mozilla.org/r/90138/#review90116

as per irc, let's make this look more like a button.
Attachment #8806824 - Flags: review?(glob) → review-
Comment on attachment 8806824 [details]
MozReview: Provide close button for dropdown dialog (Bug 1308291).

https://reviewboard.mozilla.org/r/90138/#review90158

Updated styles!
Comment on attachment 8806824 [details]
MozReview: Provide close button for dropdown dialog (Bug 1308291).

https://reviewboard.mozilla.org/r/90138/#review90278

thanks - this looks much better.

sorry, but something i didn't catch with the first patch and that impacts this one is when the 'edit header' is closed (eg. by clicking 'ok'), the button overlaps the "Markdown Reference" text.  once that's fixed we're good to go here.
Attachment #8806824 - Flags: review?(glob) → review-
Comment on attachment 8806824 [details]
MozReview: Provide close button for dropdown dialog (Bug 1308291).

https://reviewboard.mozilla.org/r/90138/#review90386

I...didn't see that -- it nestled above the link just fine in Chrome and Firefox.  Regardless, I've moved the markdown link since one displays below the textarea when the box is open.
Comment on attachment 8806824 [details]
MozReview: Provide close button for dropdown dialog (Bug 1308291).

https://reviewboard.mozilla.org/r/90138/#review90694

perfect!
Attachment #8806824 - Flags: review?(glob) → review+
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/webtools/reviewboard/rev/50788ce68e0d
MozReview: Provide close button for dropdown dialog . r=glob
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee: nobody → dwalsh
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: