1308301 - [Microsoft][ODBC SQL Server Driver][SQL Server]Incorrect syntax near '<' in Firefox only

Status: RESOLVED INCOMPLETE

(Core :: General, defect)

Description

[deborah.white]

Attachment: bill_analysis_form_bug.asp

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; rv:11.0) like Gecko

Steps to reproduce:

This works fine in IE and Chrome.  In the process of rewriting from classic asp, but need to make it work for now.  Version 43.0.1. I click on Copy previous analysis and get the error below.



Actual results:

SELECT * FROM v_bill_analysis where analysis_id = < = request.querystring("id") >

Microsoft OLE DB Provider for ODBC Drivers error '80040e14'

[Microsoft][ODBC SQL Server Driver][SQL Server]Incorrect syntax near '<'. 


Expected results:

It should have copied values from a previous record into the boxes.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Offhand, it's not clear why you would be getting different behavior in Chrome vs. Firefox. However, taking a quick look at the attached ASP page, it appears you're reflecting query parameters into your SQL statement, which looks scarily like SQL injection. That seems like a dangerous thing to do. Is there perhaps a safer way to write that code which might also avoid a potential security hole?

Comment 2

[deborah.white]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #1)
> Offhand, it's not clear why you would be getting different behavior in
> Chrome vs. Firefox. However, taking a quick look at the attached ASP page,
> it appears you're reflecting query parameters into your SQL statement, which
> looks scarily like SQL injection. That seems like a dangerous thing to do.
> Is there perhaps a safer way to write that code which might also avoid a
> potential security hole?

I realize the sql injection security issue, as I said I am working on rewriting to .NET, stored procedures, etc.  This is a strictly internal application and I am just looking for a temporary solution.  For some reason, it seems as though Firefox is not parsing the page the same way and/or changing the query.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Would you be willing/able to provide a more reduced live testcase that demonstrates the issue so we can further investigate? Otherwise, one thing that would be really helpful is if we could get a comparison of how exactly the requests are differing via the Firefox and Chrome devtools. Also, is this a new problem or something that's always been broken as far as you know? And does the issue reproduce with Firefox 49?

Comment 4

[Emil Pasca [:emilpasca]]

Hi Deborah, could you please take a look at comment 3 and see if you can provide us with more information?
Thank you.

Comment 5

[Emil Pasca [:emilpasca]]

Marking this as Resolved - Incomplete due to the lack of response from the reporter.

If anyone can still reproduce it on latest versions, feel free to reopen the issue and provide more information.

Comment 6

[Firefox Bug Husbandry Bot]

Moving from Core::Untriaged to Core::General https://bugzilla.mozilla.org/show_bug.cgi?id=1407598