Closed Bug 1308415 Opened 4 years ago Closed 4 years ago

Update about:telemetry to show keyed scalars

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client])

Attachments

(3 files)

Bug 1276198 didn't take care of adding keyed scalars to about:telemetry.

With bug 1277806 landing and keyed scalars starting to be picked up, we need to show them in about:telemetry.
Blocks: 1275517
Points: --- → 1
Priority: -- → P1
Whiteboard: [measurement:client]
Points: 1 → 2
Attached patch bug1308415.patchSplinter Review
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attached image keyed_calars1.PNG
That's the keyed scalars section rendered with the attached patch.

I'm exploding the list of keye -> value for each keyed scalar, basically rendering it the same way we do for "addons".

Another, cooler way to render this, that will pay off once we'll have more than 1 keyed scalar, is by adding the ability to toggle the key-values table for each scalar, by clicking on the keyed scalar name.

What do you think Georg, should we do it in this bug, leave it as it is, or file another bug to do the improvement work?
Attachment #8798815 - Flags: feedback?(gfritzsche)
Comment on attachment 8798815 [details]
keyed_calars1.PNG

I think this is fine for now.
Let's do this and move on, we can always revisit this later.
Attachment #8798815 - Flags: feedback?(gfritzsche) → feedback+
Attachment #8798814 - Flags: review?(gfritzsche)
Attachment #8798814 - Flags: review?(gfritzsche) → review+
This only changes about:telemetry and was tested manually, no need for a try push.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/464f24871b18
Update about:telemetry to show keyed scalars. r=gfritzsche
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/464f24871b18
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8798814 [details] [diff] [review]
bug1308415.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1277806, Bug 1303333
[User impact if declined]: The user won't be able to see search measurements gathered in about:telemetry
[Describe test coverage new/current, TreeHerder]: None. This was manually tested and lived for a while on m-c.
[Risks and why]: Low to none, as this was went through manual QA and lived for a quite a while on m-c.
[String/UUID change made/needed]: The |aboutTelemetry.keyedScalarsSection| string was added, but the about:telemetry page is meant for developer use, so there's no real rush in translating it.
Attachment #8798814 - Flags: approval-mozilla-aurora?
Comment on attachment 8798814 [details] [diff] [review]
bug1308415.patch

This patch can allow users to view the collected data for search in about:telemetry. Take it in 51 aurora.
Attachment #8798814 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8809001 - Flags: feedback?(francesco.lodolo)
Comment on attachment 8809001 [details] [diff] [review]
[AURORA ONLY] patch without string changes

Review of attachment 8809001 [details] [diff] [review]:
-----------------------------------------------------------------

The approach is correct for Aurora, thanks.
Attachment #8809001 - Flags: feedback?(francesco.lodolo) → feedback+
You need to log in before you can comment on or make changes to this bug.