Closed
Bug 1308415
Opened 8 years ago
Closed 8 years ago
Update about:telemetry to show keyed scalars
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: Dexter, Assigned: Dexter)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client])
Attachments
(3 files)
4.84 KB,
patch
|
gfritzsche
:
review+
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
12.89 KB,
image/png
|
gfritzsche
:
feedback+
|
Details |
4.36 KB,
patch
|
flod
:
feedback+
|
Details | Diff | Splinter Review |
Bug 1276198 didn't take care of adding keyed scalars to about:telemetry. With bug 1277806 landing and keyed scalars starting to be picked up, we need to show them in about:telemetry.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Points: 1 → 2
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
That's the keyed scalars section rendered with the attached patch. I'm exploding the list of keye -> value for each keyed scalar, basically rendering it the same way we do for "addons". Another, cooler way to render this, that will pay off once we'll have more than 1 keyed scalar, is by adding the ability to toggle the key-values table for each scalar, by clicking on the keyed scalar name. What do you think Georg, should we do it in this bug, leave it as it is, or file another bug to do the improvement work?
Attachment #8798815 -
Flags: feedback?(gfritzsche)
Comment 3•8 years ago
|
||
Comment on attachment 8798815 [details]
keyed_calars1.PNG
I think this is fine for now.
Let's do this and move on, we can always revisit this later.
Attachment #8798815 -
Flags: feedback?(gfritzsche) → feedback+
Assignee | ||
Updated•8 years ago
|
Attachment #8798814 -
Flags: review?(gfritzsche)
Updated•8 years ago
|
Attachment #8798814 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 4•8 years ago
|
||
This only changes about:telemetry and was tested manually, no need for a try push.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/464f24871b18 Update about:telemetry to show keyed scalars. r=gfritzsche
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/464f24871b18
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8798814 [details] [diff] [review] bug1308415.patch Approval Request Comment [Feature/regressing bug #]: Bug 1277806, Bug 1303333 [User impact if declined]: The user won't be able to see search measurements gathered in about:telemetry [Describe test coverage new/current, TreeHerder]: None. This was manually tested and lived for a while on m-c. [Risks and why]: Low to none, as this was went through manual QA and lived for a quite a while on m-c. [String/UUID change made/needed]: The |aboutTelemetry.keyedScalarsSection| string was added, but the about:telemetry page is meant for developer use, so there's no real rush in translating it.
Attachment #8798814 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
status-firefox51:
--- → affected
Comment 8•8 years ago
|
||
Comment on attachment 8798814 [details] [diff] [review] bug1308415.patch This patch can allow users to view the collected data for search in about:telemetry. Take it in 51 aurora.
Attachment #8798814 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•8 years ago
|
||
Attachment #8809001 -
Flags: feedback?(francesco.lodolo)
Comment 10•8 years ago
|
||
Comment on attachment 8809001 [details] [diff] [review] [AURORA ONLY] patch without string changes Review of attachment 8809001 [details] [diff] [review]: ----------------------------------------------------------------- The approach is correct for Aurora, thanks.
Attachment #8809001 -
Flags: feedback?(francesco.lodolo) → feedback+
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 11•8 years ago
|
||
Aurora changeset: https://hg.mozilla.org/releases/mozilla-aurora/rev/72de7d38da9e827e1e3bfa3204f8f0270477c9c9
You need to log in
before you can comment on or make changes to this bug.
Description
•