1308424 - [EME] Should verify the size of response while updating session.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Kilik Kuo [:kikuo] (inactive)]

In the test. A session response blob (larger than 64 KB) is updated into session.
Though max sizes of these data are not specified in EME spec, we should still avoid unnecessarily passing around these large parameters.

IMHO, the most suitable place to do this check is to do it asynchronously in parent side before passing the data into CDM.  But we're not able to guarantee that other CDMs would appreciate the check which is done by user agent.

So I'm adding this check in Gecko's Clearkey implementation first to pass the web-platform-test.

Comment 1

[Kilik Kuo [:kikuo] (inactive)]

Attachment: Bug 1308424-[Part1] Verify the license response size while updating session.

Review commit: https://reviewboard.mozilla.org/r/84206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84206/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8798802 [details]
Bug 1308424-[Part1] Verify the license response size while updating session.

https://reviewboard.mozilla.org/r/84206/#review83526

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f47181dc6ad7
Verify the license response size while updating session. r=cpearce

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/a6dd1257f5357fe863f23eb676e4c921827c0f94 for causing unexpected-pass orange in encrypted-media/Google/encrypted-media-update-disallowed-input.html, https://treeherder.mozilla.org/logviewer.html#?job_id=4895719&repo=autoland

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

(In reply to Phil Ringnalda (:philor) from comment #4)
> Backed out in
> https://hg.mozilla.org/integration/autoland/rev/
> a6dd1257f5357fe863f23eb676e4c921827c0f94 for causing unexpected-pass orange
> in encrypted-media/Google/encrypted-media-update-disallowed-input.html,
> https://treeherder.mozilla.org/logviewer.html#?job_id=4895719&repo=autoland

Oops, sorry for bothering, I should attach another patch to remove current unexpected meta file in central.

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

Attachment: Bug 1308424-[Part2] Remove unexpected meta file /encrypted-media/Google/encrypted-media-update-disallowed-input.html.ini

Review commit: https://reviewboard.mozilla.org/r/85248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85248/

Comment 7

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8798802 [details]
Bug 1308424-[Part1] Verify the license response size while updating session.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84206/diff/1-2/

Comment 8

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8798802 [details]
Bug 1308424-[Part1] Verify the license response size while updating session.

https://reviewboard.mozilla.org/r/84204/#review83820

Try run is added, https://treeherder.mozilla.org/#/jobs?repo=try&revision=91318f6a9628
Looks ok.

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8800293 [details]
Bug 1308424-[Part2] Remove unexpected meta file /encrypted-media/Google/encrypted-media-update-disallowed-input.html.ini

https://reviewboard.mozilla.org/r/85248/#review84960

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98efb65f865e
[Part1] Verify the license response size while updating session. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/fe325c42b181
[Part2] Remove unexpected meta file /encrypted-media/Google/encrypted-media-update-disallowed-input.html.ini r=cpearce

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98efb65f865e
https://hg.mozilla.org/mozilla-central/rev/fe325c42b181