Closed Bug 1308424 Opened 5 years ago Closed 5 years ago

[EME] Should verify the size of response while updating session.

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: kikuo, Assigned: kikuo)

References

()

Details

Attachments

(2 files)

In the test. A session response blob (larger than 64 KB) is updated into session.
Though max sizes of these data are not specified in EME spec, we should still avoid unnecessarily passing around these large parameters.

IMHO, the most suitable place to do this check is to do it asynchronously in parent side before passing the data into CDM.  But we're not able to guarantee that other CDMs would appreciate the check which is done by user agent.

So I'm adding this check in Gecko's Clearkey implementation first to pass the web-platform-test.
Attachment #8798802 - Flags: review?(cpearce)
Comment on attachment 8798802 [details]
Bug 1308424-[Part1] Verify the license response size while updating session.

https://reviewboard.mozilla.org/r/84206/#review83526
Attachment #8798802 - Flags: review?(cpearce) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f47181dc6ad7
Verify the license response size while updating session. r=cpearce
Backed out in https://hg.mozilla.org/integration/autoland/rev/a6dd1257f5357fe863f23eb676e4c921827c0f94 for causing unexpected-pass orange in encrypted-media/Google/encrypted-media-update-disallowed-input.html, https://treeherder.mozilla.org/logviewer.html#?job_id=4895719&repo=autoland
(In reply to Phil Ringnalda (:philor) from comment #4)
> Backed out in
> https://hg.mozilla.org/integration/autoland/rev/
> a6dd1257f5357fe863f23eb676e4c921827c0f94 for causing unexpected-pass orange
> in encrypted-media/Google/encrypted-media-update-disallowed-input.html,
> https://treeherder.mozilla.org/logviewer.html#?job_id=4895719&repo=autoland

Oops, sorry for bothering, I should attach another patch to remove current unexpected meta file in central.
Comment on attachment 8798802 [details]
Bug 1308424-[Part1] Verify the license response size while updating session.

https://reviewboard.mozilla.org/r/84204/#review83820

Try run is added, https://treeherder.mozilla.org/#/jobs?repo=try&revision=91318f6a9628
Looks ok.
Comment on attachment 8800293 [details]
Bug 1308424-[Part2] Remove unexpected meta file /encrypted-media/Google/encrypted-media-update-disallowed-input.html.ini

https://reviewboard.mozilla.org/r/85248/#review84960
Attachment #8800293 - Flags: review?(cpearce) → review+
Keywords: checkin-needed
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98efb65f865e
[Part1] Verify the license response size while updating session. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/fe325c42b181
[Part2] Remove unexpected meta file /encrypted-media/Google/encrypted-media-update-disallowed-input.html.ini r=cpearce
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/98efb65f865e
https://hg.mozilla.org/mozilla-central/rev/fe325c42b181
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.