1308455 - testHeapAccess.js doesn't support big-endian platforms

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Petr Sumbera]

Attachment: testHeapAccess-bigendian.diff

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459

Steps to reproduce:

Several tests in testHeapAccess.js are failing because it was written for little-endian.



Expected results:

Please see proposed attached patch (generated against FF 45.4.0 ESR). With this patch all tests form testHeapAccess.js passes on both platforms.

Comment 1

[Luke Wagner [:luke]]

OOC, are you running this with the interpreter?  I wasn't aware that our JITs supported big-endian.

Comment 2

[Petr Sumbera]

Sorry I'm beginner here. I run it as part of 'make check-jit-test' in firefox js/src tree (on sparc).

Comment 3

[Carsten Book [:Tomcat]]

seems this failed to apply:

renamed 1308455 -> testHeapAccess-bigendian.diff
applying testHeapAccess-bigendian.diff
patching file js/src/jit-test/tests/asm.js/testHeapAccess.js
Hunk #2 FAILED at 44
1 out of 4 hunks FAILED -- saving rejects to file js/src/jit-test/tests/asm.js/testHeapAccess.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh testHeapAccess-bigendian.diff

maybe need a rebase

Comment 4

[Petr Sumbera]

Attachment: Bug1308455.diff

I have merget the patch with latest FF version.

Comment 5

[Luke Wagner [:luke]]

Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e92ee7d7239
testHeapAccess.js doesn't support big-endian platforms. r=luke

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7e92ee7d7239