Closed
Bug 1308459
Opened 8 years ago
Closed 8 years ago
Rename RefreshDriver::PresContext() to hint about its behavior
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(2 files)
|
9.52 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
|
9.93 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8798831 -
Flags: review?(tnikkel)
|
||
Updated•8 years ago
|
Attachment #8798831 -
Flags: review?(tnikkel) → review+
|
Assignee | |
Comment 1•8 years ago
|
||
Apparently I had compiled only opt build, not debug build, which requires MOZ_DECLARE_WEAKREFERENCE_TYPENAME
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1eed82166f20 Rename RefreshDriver::PresContext() to hint about its behavior, r=tnikkel
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1eed82166f20
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
This patch shouldn't have landed with a commit message that says it's just renaming things when it's actually making nsPresContext implement nsISupportsWeakReference and changing nsRefreshDriver's link to the pres context to an nsWeakPtr.
You need to log in
before you can comment on or make changes to this bug.
Description
•