Merge the two netmonitor.css style files into one

RESOLVED FIXED in Firefox 52

Status

P1
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: rickychien, Assigned: jsnajdr)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 52
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [netmonitor])

Attachments

(1 attachment)

There are now two netmonitor.css files:
devtools/client/netmonitor/netmonitor.css
devtools/client/themes/netmonitor.css
We could merge them into one file in the “themes” directory

Other tools do that, too. The current division doesn’t follow any logic, it’s mostly random. Many CSS styles will get altered in the netmonitor.html project.

Updated

2 years ago
Whiteboard: [devtools-html]
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → jsnajdr

Comment 2

2 years ago
mozreview-review
Comment on attachment 8799322 [details]
Bug 1308477 - Merge the two netmonitor.css style files into one

https://reviewboard.mozilla.org/r/84532/#review83098

LGTM!

Honza
Attachment #8799322 - Flags: review?(odvarko) → review+

Comment 3

2 years ago
Pushed by jsnajdr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/515e6d07c0c2
Merge the two netmonitor.css style files into one r=Honza

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/515e6d07c0c2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

2 years ago
Iteration: --- → 52.2 - Oct 17
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [netmonitor]
Just copy-paste change, QA not needed.

Honza
Flags: qe-verify? → qe-verify-

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.