1308482 - Implement ObjectDefineProperties changes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

The MOP operation order for Object.defineProperties and Object.create changed, because they use this function.

Comment 1

[Tom S [:evilpie]]

Attachment: Implement ObjectDefineProperties changes

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8798906 [details] [diff] [review]
Implement ObjectDefineProperties changes

Review of attachment 8798906 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/Object.cpp
@@ +688,5 @@
> +    RootedId nextKey(cx);
> +    Rooted<PropertyDescriptor> desc(cx);
> +    RootedValue descObj(cx);
> +
> +    // Step

Step 4. ?

Comment 3

[Tom S [:evilpie]]

Attachment: v2 - Implement ObjectDefineProperties changes

Sorry, somehow I didn't run jit-tests before asking review. There was a somewhat subtle issue in my first patch. Because we only add enumerable descriptors to the descriptors array, we can actually get out of sync with the 'keys' array. I added a second array just for the keys we actually want to define. This is covered by jit-test/tests/proxy/testDirectProxyOwnKeysSymbol.js.

Comment 4

[Tooru Fujisawa [:arai]]

Comment on attachment 8799251 [details] [diff] [review]
v2 - Implement ObjectDefineProperties changes

Review of attachment 8799251 [details] [diff] [review]:
-----------------------------------------------------------------

wow, I should've caught it :P

::: js/src/jit-test/tests/proxy/testDirectProxyOwnKeysSymbol.js
@@ +6,4 @@
>          return [symbol, symbol2];
>      },
>      getOwnPropertyDescriptor(target, name) {
> +        print("name: " + String(name));

please remove this ;)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f92acdeafd27
Implement ObjectDefineProperties changes. r=arai

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f92acdeafd27