130849 - [TINDERBOX] unmute syntax is ambiguous

Status: RESOLVED FIXED

(Webtools Graveyard :: Mozbot, defect, P3)

Description

[Bradley Baetz (:bbaetz)]

<bbaetz> ssdbot: unmute Bugzilla in #mozillazine
<ssdbot> bbaetz: Watching for bug numbers reenabled in channel #mozillazine.
<ssdbot> bbaetz: Tinderbox notifications for trees named Bugzilla resumed in
channel #mozillazine

botbot was dead, so I just wanted to unmute bugs, not the tinderbox tree. Is
there some was of pointing my request to a specific module?

Comment 1

[Hixie (not reading bugmail)]

oops. No, there isn't. There should be. Originally, "mute X in #y" was supposed
to mute the whole of module X, when I implemented it in the Tinderbox module I
screwed that up.

how about "mute tinderbox Bugzilla in #mozillazine"? (i.e., require the
"tinderbox" prefix to mute tinderboxes).

Comment 2

[Dave Miller [:justdave]]

that would work fine for me.

I've discovered a workaround for this...   Tinderbox is case-sensitive, and
Bugzilla isn't.  So when you want to unmute the Bugzilla module, you do this:

<justdave> ssdbot unmute bugzilla in #mozillazine
<ssdbot> justdave: Watching for bug numbers reenabled in channel #mozillazine.
<ssdbot> There is no tree called bugzilla is there?.

Comment 3

[Wolf [:wolf]]

Resetting to new default owner.

Comment 4

[Wolf [:wolf]]

Attachment: Add 'tinderbox' keyword to mute.

Simple and straightforward, just changes the (un)mute <tree> in <channel> syntax to (un)mute tinderbox <tree> in <channel>

Comment 5

[Wolf [:wolf]]

Checking in BotModules/Tinderbox.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/Tinderbox.bm,v  <--  Tinderbox.bm
new revision: 2.7; previous revision: 2.6
done