Closed Bug 1308503 Opened 3 years ago Closed 3 years ago

Migrate localization strings away from certManager.dtd

Categories

(DevTools :: Netmonitor, defect, P1)

defect

Tracking

(firefox52 verified)

VERIFIED FIXED
Firefox 52
Iteration:
52.2 - Oct 17
Tracking Status
firefox52 --- verified

People

(Reporter: rickychien, Assigned: gasolin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [netmonitor])

Attachments

(1 file)

Migrate localization strings as same as bug 1308500, so there should be certManager.properties.

certManager.dtd is different with netmonitor.dtd since it is located in security folder but not devtools. We might need make a copy to not break other references.
Whiteboard: [devtools-html]
From IRC:

Honza	The Netpanel is using certManager.dtd. As part of netmonitor.html all strings should be moved into *.properties, but this DTD isn't controlled by DevTools. Should we just dup these strings?
jsnajdr	Honza: it seems that Firefox for Android had this problem, too, and ended up duplicating the strings: http://searchfox.org/mozilla-central/source/mobile/android/locales/en-US/chrome/pippki.properties#63
Honza	jsnajdr: ah, good, sounds like we could do the same


Honza
Depends on: 1295157
Assignee: nobody → gasolin
See Also: → 1294186
Whiteboard: [netmonitor]
Flags: qe-verify+
QA Contact: ciprian.georgiu
Status: NEW → ASSIGNED
Keeler, the certManager.dtd is used in devtools/netmonitor now, we plan to deXUL netmonitor, any files relying on DTDs for localization should move all the DTD entities to properties files.

Therefore we need create a counterpart for certManager.dtd. Here are two questions:

1. Do you think it's proper to host another cert-manger.properties file in netmonitor or in /security? Since currently this .properties is only used in devtools.
2. We only use small portion of certManager.dtd strings(~8), I'd prefer just copy needed strings rather than migrate whole .dtd if its fine to host another cert-manger.properties file in netmonitor


FYR, to check certManager related string in NetMonitor:

1. open yahoo.com (https)
2. Menu > Developer > Network
3. select a row, switch sidebar tab to `security` tab's certificate section
the question is in comment 2
Flags: needinfo?(dkeeler)
1. I don't have a lot of experience with l10n, but my intuition is it's best to have the strings located near to where they're used. Going by that, it would be best to put the new file in netmonitor.
2. I think it would be simplest to just use what you need (and remove any strings that aren't being used anywhere else).
Flags: needinfo?(dkeeler)
The netmonitor.properties is already exist and used by webconsole, netmonitor-view, and chart.jsm
The patch attached 8 certManager related string from certManager.dtd and ask panel render it with netmonitor.xul.
Comment on attachment 8800510 [details]
Bug 1308503 - Migrate localization strings away from certManager.dtd;

https://reviewboard.mozilla.org/r/85426/#review84108

Nice!

R+ assuming all tests on Try are green.

Honza
Attachment #8800510 - Flags: review?(odvarko) → review+
treeherder green, thanks!
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30137ab463a3
Migrate localization strings away from certManager.dtd; r=Honza
Keywords: checkin-needed
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/30137ab463a3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Iteration: --- → 52.2 - Oct 17
This issue is verified fixed on latest Nightly 52.0a1 (2016-10-23) under the following OSes:
- Windows 10 x64
- Ubuntu 16.04 x64
- macOS 10.12.1 Beta

certManager related string functionality is intact and l10n of the Security tab is not broken. Marking here accordingly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.