1308534 - [geckoview] Use e10s

Status: RESOLVED FIXED

(GeckoView :: Sandboxing, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Because it's 2016.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Use e10s in GeckoView

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8798909 [details] [diff] [review]
Use e10s in GeckoView

Review of attachment 8798909 [details] [diff] [review]:
-----------------------------------------------------------------

But it doesn't work yet?

::: widget/android/nsWindow.cpp
@@ +1357,5 @@
>          args->AppendElement(heightArg);
>      }
>  
>      nsCOMPtr<mozIDOMWindowProxy> domWindow;
> +    ww->OpenWindow(nullptr, url, nullptr, "chrome,dialog=0,resizable,scrollbars=yes",

Why do we need this change?

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Jim Chen [:jchen] [:darchons] from comment #2)
> Comment on attachment 8798909 [details] [diff] [review]
> Use e10s in GeckoView
> 
> Review of attachment 8798909 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> But it doesn't work yet?
> 

Depending on your definition, it does work with these changes. You can view pages, pan/zoom, click links.

> ::: widget/android/nsWindow.cpp
> @@ +1357,5 @@
> >          args->AppendElement(heightArg);
> >      }
> >  
> >      nsCOMPtr<mozIDOMWindowProxy> domWindow;
> > +    ww->OpenWindow(nullptr, url, nullptr, "chrome,dialog=0,resizable,scrollbars=yes",
> 
> Why do we need this change?

Without this, the browser is marked as not scrollable and you can't pan.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/163950628bd3
Use e10s in GeckoView r=jchen

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/163950628bd3

Comment 6

[Chris Peterson [:cpeterson]]

Moving some e10s bugs to the new GeckoView::Sandboxing component.