If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Deal with Bug 1296317 changing VerifyCert() and VerifySSLServerCert() to return mozilla::pkix::Result instead of SECStatus

RESOLVED FIXED in Thunderbird 52.0

Status

MailNews Core
Security: S/MIME
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: Cykesiopka, Unassigned)

Tracking

unspecified
Thunderbird 52.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Bug 1296317 will change VerifyCert() and VerifySSLServerCert() to return mozilla::pkix::Result instead of SECStatus.

c-c code will need to be updated to deal with this.
(Reporter)

Comment 1

a year ago
Created attachment 8798943 [details] [diff] [review]
bug1308548_VerifyCert-VerifySSLServerCert-port-switch-to-pkix-Result_v1.patch

This compiles on my machine for TB, but I haven't tested that the features still work. If it doesn't work, then at least this patch is a starting point.
Attachment #8798943 - Flags: review?(rkent)
(Reporter)

Updated

a year ago
Duplicate of this bug: 1309126

Comment 3

11 months ago
Comment on attachment 8798943 [details] [diff] [review]
bug1308548_VerifyCert-VerifySSLServerCert-port-switch-to-pkix-Result_v1.patch

Review of attachment 8798943 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, much appreciated!
Attachment #8798943 - Flags: review?(rkent) → review+

Comment 4

11 months ago
https://hg.mozilla.org/comm-central/rev/6d463070d845ed47088ee322e0bca4dc4bf12ae3
We'll reopen if something doesn't work (which I doubt).
Thanks again!!
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.