fix password and email change UI

NEW
Assigned to

Status

()

bugzilla.mozilla.org
General
2 years ago
a year ago

People

(Reporter: Jonathan Dupré, Assigned: dylan)

Tracking

Production

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161006004005

Steps to reproduce:

1. Navigate to 'preferences' (userprefs.cgi)
2. Make sure the 'account' tab is selected (it should be selected by default)
3. Enter current password in 'Current password' input field
3. Enter an e-mail address in 'New email address' input field
4. Click submit changes


Actual results:

A popover opens over the 'new password' input field:
  "Password does not meet requirements"
The forms seems to assume I am trying to change my password.


Expected results:

The form states that my "...current password is required to confirm ... email address changes." Having entered my existing password and a new password, it should let me change my e-mail address.
(Reporter)

Comment 1

2 years ago
Update:

Steps to reproduce should include between #2 and #3 : 
  "Change value of 'real name' input field".
(Assignee)

Comment 2

2 years ago
I guess this was a side effect of the password complexity. Let me see if I can't make this a better experience.

Thanks for the bug report.
Assignee: nobody → dylan
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

2 years ago
Created attachment 8799097 [details] [diff] [review]
1308550_2.patch

Fixes the reported bug but also makes the page a little bit nicer to use, I think.
Attachment #8799097 - Flags: review?(dkl)
(Assignee)

Comment 4

2 years ago
Created attachment 8799098 [details]
Screen Shot 2016-10-08 at 00.38.41.png
Comment on attachment 8799097 [details] [diff] [review]
1308550_2.patch

Review of attachment 8799097 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but IMO (I forgot my password) should just go away since the user is already logged in and they can see a forgotten password link at the top right when not logged in.

So just narrow down to:

> Change Password
> Change Email

Also add the small arrow icon next to them to be consistent with the 'Disable My Account' section.

If password_complexity is set to 'no_constraints' instead of 'bmo', the password meter is still show on the right even though it doesn't do anything.

dkl
Attachment #8799097 - Flags: review?(dkl) → review-
(Assignee)

Updated

a year ago
Summary: change e-mail → fix password and email change UI
You need to log in before you can comment on or make changes to this bug.