1308587 - Use script to remove -moz- prefixes from all usages of CSS multi-column properties in the tree (except for code that adds/intentionally-targets prefixed aliases)

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Neerja Pancholi[:neerja]]

This bug is step (4) from Bug 698783 comment#12

Comment 1

[Daniel Holbert [:dholbert]]

[--> Clarifying summary a bit to better-distinguish it from bug 698783 and bug 1300895.]

Comment 2

[Neerja Pancholi[:neerja]]

Attachment: Bug 1308587 - Use script to remove -moz- prefixes from all usages of CSS multi-column properties in the tree

Command used:
find ./* -type f | xargs egrep -ls '.*-moz-column.*' | xargs sed -i '' 's/-moz-column/column/g'

Exceptions to this substitution:
1. nsCSSAnonBoxList.h
2. nsCSSPropAliasList.h
3. property_database.js
4. properties-db.js

Review commit: https://reviewboard.mozilla.org/r/84974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84974/

Comment 3

[David Baron :dbaron:]

Comment on attachment 8799907 [details]
Bug 1308587 - Use script to remove -moz- prefixes from all usages of CSS multi-column properties in the tree

https://reviewboard.mozilla.org/r/84974/#review85260

We should wait to do this until it's clear that the unprefixing has stuck (i.e., shipped on release).

Cancelling review request for now.

Comment 4

[Neerja Pancholi[:neerja]]

(In reply to David Baron :dbaron: ⌚️UTC-7 from comment #3)
> Comment on attachment 8799907 [details]
> Bug 1308587 - Use script to remove -moz- prefixes from all usages of CSS
> multi-column properties in the tree
> 
> https://reviewboard.mozilla.org/r/84974/#review85260
> 
> We should wait to do this until it's clear that the unprefixing has stuck
> (i.e., shipped on release).
> 
> Cancelling review request for now.

Alright. Thanks David.

Comment 5

[ExE Boss]

Well, considering that it’s been two years since the last comment, and Firefox release now supports the unprefixed `column-*` properties (including the last two ESR versions), work on this bug should probably be re-started (as searching through the tree reveals that `-moz-column-*` properties are still in use in some stylesheets in the tree).

At the same time, the patch no longer seems to reflect what’s in the Firefox codebase, and therefore needs rebasing.

Comment 6

[Daniel Holbert [:dholbert]]

The patch's commit message includes the command that was used to generate the patch, so presumably somebody can re-run that command again (or a similar command) to generate an up-to-date patch.

Comment 7

[ExE Boss]

Attachment: debugger.html upstream pull-request

I’ve submitted a PR to the devtools.html repository, which upstreams the `‑moz‑column‑*` changes there.

Comment 8

[Ting-Yu Lin [:TYLin] (UTC-8)]

Attachment: Bug 1308587 Part 1 - Manually remove "-moz" prefixed multi-column properties in some tests.

In the next part, the patch generated by a script removes "-moz" prefix
to all multi-column properties.

However, some of the tests already have standard multi-column properties
specified. To avoid duplicating CSS multi-column rules in these
files (after applying the next part), I manually remove the prefixed
rules beforehand as many as possible.

Comment 9

[Ting-Yu Lin [:TYLin] (UTC-8)]

Attachment: Bug 1308587 Part 2 - Remove -moz prefix for all multi-column properties in testing and css files.

This patch is generated by the following script:

function remove_column_prefix() {
    echo "Renaming $1 to $2"
    find .\
         -type f\
         ! -path "./obj*"\
         ! -path "./.git"\
         ! -path "./.hg"\
         \( -name "*.html" -or\
            -name "*.xhtml" -or\
            -name "*.xht" -or\
            -name "*.xul" -or\
            -name "*.css"  \)\
            -exec sed -i -e "s/$1/$2/g" "{}" \;
}

remove_column_prefix "-moz-columns" "columns"
remove_column_prefix "-moz-column-width" "column-width"
remove_column_prefix "-moz-column-count" "column-count"
remove_column_prefix "-moz-column-fill" "column-fill"
remove_column_prefix "-moz-column-gap" "column-gap"
remove_column_prefix "-moz-column-rule" "column-rule"
remove_column_prefix "-moz-column-rule-width" "column-rule-width"
remove_column_prefix "-moz-column-rule-color" "column-rule-color"
remove_column_prefix "-moz-column-rule-style" "column-rule-style"

Depends on D44869

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a31610c04020
Part 1 - Manually remove "-moz" prefixed multi-column properties in some tests. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/bb59a0c37162
Part 2 - Remove -moz prefix for all multi-column properties in testing and css files. r=dholbert

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18884 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a31610c04020
https://hg.mozilla.org/mozilla-central/rev/bb59a0c37162

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Ting-Yu Lin [:TYLin] (UTC-8)]

Attachment: Bug 1308587 Part 1 - Convert -moz-column-span to column-span in a crashtest. r=dbaron

-moz-column-span missed the conversion in Bug 1308587 Part 2.
https://hg.mozilla.org/mozilla-central/rev/bb59a0c37162

Comment 16

[Phabricator Automation]

Comment on attachment 9120164 [details]
Bug 1308587 Part 1 - Convert -moz-column-span to column-span in a crashtest. r=dbaron

Revision D59562 was moved to bug 1308636. Setting attachment 9120164 [details] to obsolete.