Closed
Bug 1308611
Opened 8 years ago
Closed 8 years ago
Convert |nsISHEntry.refreshURIList| to |nsIArray|
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
13.83 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|nsISupportsArray| is deprecated. It looks like it should be straightforward to convert |refreshURIList| to an nsIArray as nsDocShell.cpp is the only consumer. A textual search of the addons repo shows no hits.
|
Assignee | |
Comment 1•8 years ago
|
||
|refreshURIList| is converted to a an nsIMutableArray as nsISupportsArray is deprecated. This attribute is only used internally and does not show up in a textual search of the plugins repo. nsIMutableArray is used rather than nsIArray in order to support modifying the array as current users expect. I was going to have bz review this but they're not accepting reviews. MozReview-Commit-ID: F0GYVFZarOQ
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8799084 [details] [diff] [review] Convert nsISHEntry.refreshURIList to nsIMutableArray r=me, but this stuff is so ugly.... Not your fault, anyway.
Attachment #8799084 -
Flags: review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6888254eb1c343e9146ef2b8974a4d4f5b80e7ac Bug 1308611 - Convert nsISHEntry.refreshURIList to nsIMutableArray. r=bz
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6888254eb1c3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•