Closed Bug 1308611 Opened 4 years ago Closed 4 years ago

Convert |nsISHEntry.refreshURIList| to |nsIArray|

Categories

(Core :: DOM: Navigation, defect)

48 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

|nsISupportsArray| is deprecated. It looks like it should be straightforward to convert |refreshURIList| to an nsIArray as nsDocShell.cpp is the only consumer. A textual search of the addons repo shows no hits.
|refreshURIList| is converted to a an nsIMutableArray as nsISupportsArray is
deprecated. This attribute is only used internally and does not show up in a
textual search of the plugins repo.

nsIMutableArray is used rather than nsIArray in order to support modifying the
array as current users expect.

I was going to have bz review this but they're not accepting reviews.

MozReview-Commit-ID: F0GYVFZarOQ
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8799084 [details] [diff] [review]
Convert nsISHEntry.refreshURIList to nsIMutableArray

r=me, but this stuff is so ugly.... Not your fault, anyway.
Attachment #8799084 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/6888254eb1c3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.