Closed Bug 1308621 Opened 3 years ago Closed 3 years ago

Fix some browser confusion in print preview code

Categories

(Core :: Print Preview, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

Details

Attachments

(1 file)

This came to light due to earlier code changes in print preview.
Attachment #8799031 - Flags: review?(florian)
Hey mlongaray - do you think this is also likely to fix bug 1308461?
Flags: needinfo?(mlongaray)
Hey Mike, it certainly fixes the clobbering issue I was referring to on IRC, but unfortunately does not fix bug 1308461. I applied this patch and bug 1308461 still persists. Thank you for this work, Gijs.
Flags: needinfo?(mlongaray)
Comment on attachment 8799031 [details]
Bug 1308621 - print preview shouldn't re-set the source browser,

https://reviewboard.mozilla.org/r/84330/#review83160

Looks good given the context I've read, but it's the first time I look at print preview code, so I may be missing some subtleties.
Attachment #8799031 - Flags: review?(florian) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b5d1247e02ed
print preview shouldn't re-set the source browser, r=florian
https://hg.mozilla.org/mozilla-central/rev/b5d1247e02ed
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.