1308633 - Receiving a push notification while Fennec is not running causes a crash

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Dylan Roeh (:droeh) (he/him)]

If we receive a push notification while Fennec is not running, we crash in NotificationClient.showNotification(), as GeckoAppShell.getGeckoInterface() is null.

To reproduce: Run the demo at https://serviceworke.rs/push-simple_demo.html and leave enough time to kill Fennec in the app switcher before the notification arrives.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Fail (somewhat) gracefully if we can't get ComponentName

This patch just uses empty strings for the package name and class name in cases where we cannot get the ComponentName. It's probably not a great solution, so I'm open to other suggestions/ideas.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8799040 [details] [diff] [review]
Fail (somewhat) gracefully if we can't get ComponentName

Review of attachment 8799040 [details] [diff] [review]:
-----------------------------------------------------------------

Use AppConstants.ANDROID_PACKAGE_NAME and AppConstants.MOZ_ANDROID_BROWSER_INTENT_CLASS as defaults.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e6738db2f92
Use predefined strings for package name and class name when we cannot get the ComponentName in NotificationClient.showNotification. r=jchen

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8e6738db2f92