Intermittent tests\jit-test\jit-test\tests\basic\bug1296249.js | Timeout (code 1, args "--ion-eager --ion-offthread-compile=off --non-writable-jitcode --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads")

RESOLVED FIXED in Firefox 51

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: intermittent-bug-filer, Assigned: sandervv)

Tracking

({intermittent-failure})

unspecified
mozilla52
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51 fixed, firefox52 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Duplicate of this bug: 1308668
It seems that the testcase added in bug 1296249 takes a lot of time.
Can we make it quicker by decreasing the number of items it needs to allocate and still have the testcase triggering on the issue that was fixed by that bug?
Blocks: 1296249
Flags: needinfo?(sandervv)
Priority: -- → P1
17 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 7
* autoland: 6
* mozilla-central: 2
* fx-team: 2

Platform breakdown:
* windows8-64: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-03&endday=2016-10-09&tree=all
(Assignee)

Comment 4

2 years ago
Since the bug happens on windows8-64 only, and the link you gave suggests that it only a problem on the debug builds, I found this info about malloc on windows8 64-bit and debug builds: https://msdn.microsoft.com/en-us/library/974tc9t1.aspx

"The debug heap also fills new memory blocks with a known value." (Note the debug heap is used when _DEBUG is not defined.)

I think that memset()ing the huge amount of memory during debug mode is causing the timeout. What do you think?

I think that the fix is to disable memset()ing huge memory allocations by using _IGNORE_BLOCK during _malloc_dbg() while in debug mode on windows 8 64-bit: https://msdn.microsoft.com/en-us/library/974tc9t1.aspx#BKMK_Types_of_blocks_on_the_debug_heap
Flags: needinfo?(sandervv) → needinfo?(hv1989)
(In reply to Sander Mathijs van Veen from comment #4)
> I think that memset()ing the huge amount of memory during debug mode is
> causing the timeout. What do you think?

That totally makes sense. The extra things in debug builds probably takes a lot more time. Not sure we should disable those extra "checks". If we could decrease the runtime while still testing the "bug" this revision fixed, we would have both. Else we might just add it to the long-running list.
Flags: needinfo?(hv1989)
24 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 10
* mozilla-inbound: 7
* fx-team: 5
* mozilla-central: 2

Platform breakdown:
* windows8-64: 24

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-11&endday=2016-10-11&tree=all
17 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 9
* autoland: 5
* fx-team: 2
* mozilla-central: 1

Platform breakdown:
* windows8-64: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-12&endday=2016-10-12&tree=all
status-firefox50: --- → unaffected
status-firefox51: --- → affected
status-firefox52: --- → affected
(Assignee)

Comment 8

2 years ago
Created attachment 8800768 [details] [diff] [review]
bug1308647-disable-malloc-memset-on-windows-debug.patch

Added js function that we discussed on IRC.

Try job results are good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=88a9035861e3e75ba35390ae40623569fff8b562
Although I'm not sure if I've selected the right try job options to execute the jit tests on windows 8.
Assignee: nobody → sandervv
Attachment #8800768 - Flags: review?(hv1989)
19 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 6
* autoland: 5
* mozilla-aurora: 4
* mozilla-central: 2
* fx-team: 2

Platform breakdown:
* windows8-64: 19

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-13&endday=2016-10-13&tree=all
Comment on attachment 8800768 [details] [diff] [review]
bug1308647-disable-malloc-memset-on-windows-debug.patch

Review of attachment 8800768 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8800768 - Flags: review?(hv1989) → review+
Win8 debug on that Try push doesn't look amused.
15 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 7
* autoland: 4
* mozilla-aurora: 2
* try: 1
* fx-team: 1

Platform breakdown:
* windows8-64: 14
* osx-10-7: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-14&endday=2016-10-14&tree=all
104 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 39
* autoland: 33
* fx-team: 13
* mozilla-aurora: 9
* mozilla-central: 7
* try: 3

Platform breakdown:
* windows8-64: 102
* osx-10-7: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-10&endday=2016-10-16&tree=all
(Assignee)

Comment 14

2 years ago
Created attachment 8801661 [details] [diff] [review]
bug1308647-mark-bug1296249-as-slow.patch

Marked test case as slow, as discussed on IRC.
Attachment #8800768 - Attachment is obsolete: true
Attachment #8801661 - Flags: review?(hv1989)
Attachment #8801661 - Flags: review?(hv1989) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
15 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 7
* mozilla-inbound: 4
* mozilla-central: 2
* mozilla-aurora: 2

Platform breakdown:
* windows8-64: 15

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-17&endday=2016-10-17&tree=all

Comment 16

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48955fa87451
Mark testcase of bug1296249 as slow. r=h4writer
Keywords: checkin-needed
19 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 8
* mozilla-inbound: 3
* mozilla-central: 3
* fx-team: 3
* try: 1
* mozilla-aurora: 1

Platform breakdown:
* windows8-64: 19

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-18&endday=2016-10-18&tree=all

Comment 18

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/48955fa87451
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Whiteboard: [checkin-needed-aurora]

Comment 19

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/4c20c80bf18a
status-firefox51: affected → fixed
Whiteboard: [checkin-needed-aurora]
45 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 16
* mozilla-aurora: 11
* mozilla-inbound: 8
* mozilla-central: 6
* fx-team: 3
* try: 1

Platform breakdown:
* windows8-64: 45

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1308647&startday=2016-10-17&endday=2016-10-23&tree=all
You need to log in before you can comment on or make changes to this bug.