Closed Bug 1308708 Opened 5 years ago Closed 5 years ago

Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 52.0

People

(Reporter: aryx, Assigned: aryx)

Details

Attachments

(2 files)

In bug 1304829, I am renaming RELEASE_BUILD to RELEASE_OR_BETA. This has already landed on mozilla-inbound.
Comment on attachment 8799108 [details]
Bug 1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: suite.

> -#ifdef RELEASE_BUILD
> +#ifdef RELEASE_OR_BETA
>  // Give the user x seconds to react before showing the big UI. default=8 days
>  pref("app.update.promptWaitTime", 691200);
>  #else
>  // For nightly and aurora builds, before showing the big UI, default=12 hrs
>  pref("app.update.promptWaitTime", 43200);
>  #endif
This looks reasonable. r+

>      <!-- REMOVE #ifndef once EME are ready for prime time, meta bug 1015800 -->
> -#ifndef RELEASE_BUILD
> +#ifndef RELEASE_OR_BETA
I'll need rsx11m to confirm if this change is correct.
f?rsx11m
Attachment #8799108 - Flags: review+
Attachment #8799108 - Flags: feedback?(rsx11m.pub)
Comment on attachment 8799108 [details]
Bug 1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: suite.

This is strictly for development at this time only, given that the EME stuff yet needs to be finalized. Thus, hiding the panel for beta already should be fine.
Attachment #8799108 - Flags: feedback?(rsx11m.pub) → feedback+
Attachment #8799107 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8799107 [details]
Bug 1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: mail.

No idea how this review board works.
Attachment #8799107 - Flags: review?(mkmelin+mozilla) → review+
mail: https://hg.mozilla.org/comm-central/rev/dac4e613107ff2e60dc63b92451d0640338322b2
suite: https://hg.mozilla.org/comm-central/rev/ff8ccf6949cb01847dd2419e2da80357df9283db
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Version: unspecified → 52
(In reply to rsx11m from comment #4)
> This is strictly for development at this time only, given that the EME stuff
> yet needs to be finalized. Thus, hiding the panel for beta already should be
> fine.
This is no change in behavior, it was already hidden on beta before, the switch just gets renamed to make this more obvious.

(In reply to Jorg K (GMT+2) from comment #5)
> No idea how this review board works.
See 1308768 , especially "Interacting with Review Board". Some features like pushing from reviewboard are unavailable for c-c.
You need to log in before you can comment on or make changes to this bug.