1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

In bug 1304829, I am renaming RELEASE_BUILD to RELEASE_OR_BETA. This has already landed on mozilla-inbound.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: mail.

Review commit: https://reviewboard.mozilla.org/r/84406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84406/

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: suite.

Review commit: https://reviewboard.mozilla.org/r/84408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84408/

Comment 3

[Philip Chee]

Comment on attachment 8799108 [details]
Bug 1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: suite.

> -#ifdef RELEASE_BUILD
> +#ifdef RELEASE_OR_BETA
>  // Give the user x seconds to react before showing the big UI. default=8 days
>  pref("app.update.promptWaitTime", 691200);
>  #else
>  // For nightly and aurora builds, before showing the big UI, default=12 hrs
>  pref("app.update.promptWaitTime", 43200);
>  #endif
This looks reasonable. r+

>      <!-- REMOVE #ifndef once EME are ready for prime time, meta bug 1015800 -->
> -#ifndef RELEASE_BUILD
> +#ifndef RELEASE_OR_BETA
I'll need rsx11m to confirm if this change is correct.
f?rsx11m

Comment 4

[rsx11m]

Comment on attachment 8799108 [details]
Bug 1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: suite.

This is strictly for development at this time only, given that the EME stuff yet needs to be finalized. Thus, hiding the panel for beta already should be fine.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8799107 [details]
Bug 1308708 - Port bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: mail.

No idea how this review board works.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

mail: https://hg.mozilla.org/comm-central/rev/dac4e613107ff2e60dc63b92451d0640338322b2
suite: https://hg.mozilla.org/comm-central/rev/ff8ccf6949cb01847dd2419e2da80357df9283db

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to rsx11m from comment #4)
> This is strictly for development at this time only, given that the EME stuff
> yet needs to be finalized. Thus, hiding the panel for beta already should be
> fine.
This is no change in behavior, it was already hidden on beta before, the switch just gets renamed to make this more obvious.

(In reply to Jorg K (GMT+2) from comment #5)
> No idea how this review board works.
See 1308768 , especially "Interacting with Review Board". Some features like pushing from reviewboard are unavailable for c-c.