Closed
Bug 1308742
Opened 9 years ago
Closed 9 years ago
Line breaks show up as \n in the new console frontend
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox49 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 verified)
VERIFIED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | unaffected |
| firefox50 | --- | unaffected |
| firefox51 | --- | unaffected |
| firefox52 | --- | verified |
People
(Reporter: mstange, Assigned: Honza)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
3.66 KB,
patch
|
linclark
:
review+
|
Details | Diff | Splinter Review |
console.log("Hello\nWorld") shows
> Hello\nWorld
but it should show
> Hello
> World
That's what the old console did and it's also what other browsers are doing.
|
||
Comment 1•9 years ago
|
||
I tested on Mac OS X 10.10 with FF 52 (2016-10-09) and I can reproduce it. I run mozregression and here is the pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=37f78aca862224d7151c0fcae1ed8373fe11c83b&tochange=a5510966f80b9b2f5abf59ab32cf4c92d66c60de
status-firefox49:
--- → unaffected
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
status-firefox52:
--- → affected
|
|
||
Comment 2•9 years ago
|
||
This is due to the use of Reps in the new console frontend. Honza, what do you think about this one?
Flags: needinfo?(odvarko)
Priority: -- → P3
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #2)
> This is due to the use of Reps in the new console frontend. Honza, what do
> you think about this one?
This looks like a bug for me. String rep should preserve line breaks.
Patch attached.
Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
Attachment #8801709 -
Flags: review?(lclark)
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8801709 [details] [diff] [review]
bug1308742.patch
Review of attachment 8801709 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, thanks!
Attachment #8801709 -
Flags: review?(lclark) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/480e384e3e66
Preserve line breaks in String rep; r=linclark
Keywords: checkin-needed
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
|
||
Comment 9•9 years ago
|
||
I verified this on Mac OS X 10.10 with FF Nightly 52.0a1(2016-10-19) I can confirm the fix. The bug is no longer reproducible.
Status: RESOLVED → VERIFIED
|
||
Updated•9 years ago
|
Version: unspecified → Trunk
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•