Closed
Bug 1308824
Opened 8 years ago
Closed 8 years ago
add vcruntime140.dll to skiplist
Categories
(Socorro :: General, task)
Socorro
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: m_kato, Assigned: m_kato)
Details
Like bug 1161067, we should add vcruntime140\.dll to prefix skiplist.
|
Assignee | |
Comment 1•8 years ago
|
||
PR. https://github.com/mozilla/socorro/pull/3511
|
||
Updated•8 years ago
|
Component: Symbols → General
|
||
Comment 2•8 years ago
|
||
Hey Makoto, do you also want to add that dll to the Trim DLL Signatures list? See https://github.com/mozilla/socorro/tree/master/socorro/siglists#trim-dll-signatures for explanations. I think you might be interested in doing it, but if not let me know and I'll merge your pull request. Thanks for helping with Socorro! :)
Assignee: nobody → m_kato
Flags: needinfo?(m_kato)
|
|
Assignee | |
Comment 3•8 years ago
|
||
(In reply to Adrian Gaudebert [:adrian] from comment #2) > Hey Makoto, do you also want to add that dll to the Trim DLL Signatures > list? No, we don't update vc runtime version per build, so offset is also important.
Flags: needinfo?(m_kato)
|
||
Comment 4•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/4b614cf595904bde50ce7fd151bf12ea415dd30e Bug 1308824 - add vcruntime140.dll to skiplist (#3511)
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•