Closed
Bug 1308841
Opened 8 years ago
Closed 8 years ago
Bookmark validator should check all expected roots exist locally on the client
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: markh, Assigned: tcsc)
Details
Attachments
(1 file)
In bug 670069 we see a places.sqlite that doesn't appear truly corrupt, but the "toolbar" root is missing. This should be impossible. It might make sense to have the validator check the local roots (eg, something like (a) all expected roots exist and (b) they all have the "places" root as a parent). That should help us determine if it is worthwhile having places do this as part of its own sanity checks.
|
||
Updated•8 years ago
|
Assignee: nobody → tchiovoloni
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8799860 [details] Bug 1308841 - Sanity check client-side bookmark roots in sync validator https://reviewboard.mozilla.org/r/84948/#review83632
Attachment #8799860 -
Flags: review?(markh) → review+
| Comment hidden (mozreview-request) |
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62f88acbfd5a Sanity check client-side bookmark roots in sync validator r=markh
| Comment hidden (mozreview-request) |
I had to back this out for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=4944039&repo=autoland https://hg.mozilla.org/integration/autoland/rev/886abcf6a269
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f3cb3753094 Sanity check client-side bookmark roots in sync validator r=markh
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8f3cb3753094
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in
before you can comment on or make changes to this bug.
Description
•