1308842 - Fix scrolling behaviour when opening stacktraces/groups

Status: NEW

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

If there's a lot of message, expanding a group/stacktrace make the console scrolls to the bottom of the page, which can "hide" the group/stacktrace we want to see.
When expanding a stacktrace, we should stay in the same place and see the stacktrace.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

STR: 
1. Open the URL (data:text/html,<script type="text/javascript">console.groupCollapsed("a");console.log("a");console.groupEnd("a");for(var i=0;i<200;i++)console.log(i);</script>)
2. Open the console
3. Scroll up to the 
4. Open the "a" group

Expected result : The group opens and reveals the "a" message, the console does not scroll
Actual result: The group opens and reveals the "a" message, but the console scrolls way down to the bottom, and this the message is not visible in the viewport.

Comment 2

[Lin Clark [:linclark]]

There's a decent chance this will be fixed with Bug 1307932

Comment 3

[Lin Clark [:linclark]]

Also, I'm going to be testing using react-virtualized to help with performance. If that's the case, then the way we handle scrolling will be different.

Comment 4

[Patrick Brosset <:pbro>]

As per the DevTools triage process doc [1], a P1 is defined as:
- a security hole
- causing data-loss
- causing a crash
- stopping the tools working
- embarrassing
Should be fixed within 24h and your manager should know about it and, between you, assign it to someone who can fix it.

Maybe the "24h" part of this definition is a little too much and we should change it, but anyway, this does seem like a P1 and it should be assigned.

[1] https://docs.google.com/document/d/1uG0foc0pphXJB489_8ClKjYr1wbRXeFyrkd_kIOv9ao/edit#

Comment 5

[Lin Clark [:linclark]]

This is likely to be fixed with the perf work, so removing the P1 status.

Comment 6

[Lin Clark [:linclark]]

This will likely be fixed by Bug 1308216

Comment 7

[Zac Svoboda :zacnomore]

This works correctly and does not scroll back to the bottom as of FF 84.